You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by lu...@apache.org on 2009/08/09 12:07:06 UTC
svn commit: r802509 - /commons/sandbox/nabla/trunk/checkstyle.xml
Author: luc
Date: Sun Aug 9 10:07:05 2009
New Revision: 802509
URL: http://svn.apache.org/viewvc?rev=802509&view=rev
Log:
prevent checkstyle from complaining about missing hidden constructor in LazyHolder classes
these classes are private internal classes and completely under control, there is no
risk anyone instantiate them and in fact it would not harm either.
Adding an hidden constructor to make checkstyle happy would make cobertura unhappy and displaying
very low coverage since cobertura currently (August 2009) cannot mark untestable methods, so it
seems better to use checkstyle filtering feature in these specific and controlled cases
Modified:
commons/sandbox/nabla/trunk/checkstyle.xml
Modified: commons/sandbox/nabla/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/sandbox/nabla/trunk/checkstyle.xml?rev=802509&r1=802508&r2=802509&view=diff
==============================================================================
--- commons/sandbox/nabla/trunk/checkstyle.xml (original)
+++ commons/sandbox/nabla/trunk/checkstyle.xml Sun Aug 9 10:07:05 2009
@@ -83,6 +83,19 @@
PLUS_ASSIGN, QUESTION, RCURLY, SL, SLIST, SL_ASSIGN, SR,
SR_ASSIGN, STAR, STAR_ASSIGN"/>
</module>
- </module>
- <module name="NewlineAtEndOfFile"/>
+
+ <!-- Required for SuppressionCommentFilter below -->
+ <module name="FileContentsHolder"/>
+
+ </module>
+
+ <!-- Setup special comments to suppress specific checks from source files -->
+ <module name="SuppressionCommentFilter">
+ <property name="offCommentFormat" value="CHECKSTYLE\: stop HideUtilityClassConstructor"/>
+ <property name="onCommentFormat" value="CHECKSTYLE\: resume HideUtilityClassConstructor"/>
+ <property name="checkFormat" value="HideUtilityClassConstructor"/>
+ </module>
+
+ <module name="NewlineAtEndOfFile"/>
+
</module>