You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/01 21:12:37 UTC

[GitHub] [arrow] returnString opened a new pull request #8322: ARROW-9520: [Rust] [DataFusion] Add support for aliased aggregate exprs

returnString opened a new pull request #8322:
URL: https://github.com/apache/arrow/pull/8322


   First attempt at contributing to Arrow/DataFusion, just fixing this small issue around aliased aggregate columns. Please let me know if this isn't an ideal implementation!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8322: ARROW-9520: [Rust] [DataFusion] Add support for aliased aggregate exprs

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8322:
URL: https://github.com/apache/arrow/pull/8322#issuecomment-702500265


   Thanks @returnString this looks great but you'll need to run `cargo +stable fmt --all` to fix the linter check in CI before we can merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #8322: ARROW-9520: [Rust] [DataFusion] Add support for aliased aggregate exprs

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8322:
URL: https://github.com/apache/arrow/pull/8322#issuecomment-702631071


   > Are squash merges accepted for this project or would you prefer that I rebase the PR down to a single commit?
   
   There is some sort of automation script that merges arrow PRs -- I don't think there is any need to rebase to a single commit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8322: ARROW-9520: [Rust] [DataFusion] Add support for aliased aggregate exprs

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8322:
URL: https://github.com/apache/arrow/pull/8322#issuecomment-702406457


   https://issues.apache.org/jira/browse/ARROW-9520


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #8322: ARROW-9520: [Rust] [DataFusion] Add support for aliased aggregate exprs

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8322:
URL: https://github.com/apache/arrow/pull/8322#issuecomment-702498683


   Can you run locally `cargo fmt`, so that we fix all linting issues shown in the CI pipeline?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] returnString commented on pull request #8322: ARROW-9520: [Rust] [DataFusion] Add support for aliased aggregate exprs

Posted by GitBox <gi...@apache.org>.
returnString commented on pull request #8322:
URL: https://github.com/apache/arrow/pull/8322#issuecomment-702621373


   That's interesting, I've got rustfmt set to run on save whilst editing in vscode but I _was_ having some issues with code completion in the project too; I'll try and figure out what's up with that for any future contributions.
   
   Are squash merges accepted for this project or would you prefer that I rebase the PR down to a single commit?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove closed pull request #8322: ARROW-9520: [Rust] [DataFusion] Add support for aliased aggregate exprs

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8322:
URL: https://github.com/apache/arrow/pull/8322


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org