[jira] [Commented] (HADOOP-5732) SFTP FileSystem

["Chris Douglas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535555#comment-14535555 ] 

Chris Douglas commented on HADOOP-5732:
---------------------------------------

Thanks for updating the patch, Ram.

>From the discussion a few years back, we may want to just punt on the unit test. Since it's ignored (and a "correct" one would be difficult to write), there's not a lot of value in committing it.

Feedback on the patch (not necessarily blocking):
* The "soft" limit this imposes on the connection pool should be documented
* {{SFTPConnectionPool}} should be package-private
* Throwing a {{RuntimeException}} instead of {{IOException}} is excessive, as in {{SFTPInputStream}} (this particular case is not correct; {{close()}} should be idempotent)

> SFTP FileSystem
> ---------------
>
>                 Key: HADOOP-5732
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5732
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs
>    Affects Versions: 0.20.0
>         Environment: Any environment
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Minor
>         Attachments: HADOOP-5732.008.patch, HADOOP-5732.patch, HADOOP-5732.patch, HADOOP-5732.patch, HADOOP-5732.patch, HADOOP-5732.patch, ivy-for-hadoop-7532.patch, ivy-for-hadoop-7532.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I have implemented a FileSystem that supports SFTP. It uses JSch (http://www.jcraft.com/jsch/) in order to manage SFTP.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)