You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/12 08:36:14 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request #13570: support function parse on pg/og
tuichenchuxin opened a new pull request #13570:
URL: https://github.com/apache/shardingsphere/pull/13570
refer to #13314.
Changes proposed in this pull request:
- support function parse on pg/og.
- modify test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #13570: support function parse on pg/og
Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #13570:
URL: https://github.com/apache/shardingsphere/pull/13570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13570: support function parse on pg/og
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #13570:
URL: https://github.com/apache/shardingsphere/pull/13570#discussion_r748070935
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-opengauss/src/main/java/org/apache/shardingsphere/sql/parser/opengauss/visitor/statement/impl/OpenGaussStatementSQLVisitor.java
##########
@@ -531,6 +527,9 @@ public final ASTNode visitSortby(final SortbyContext ctx) {
LiteralExpressionSegment index = (LiteralExpressionSegment) astNode;
return new IndexOrderByItemSegment(index.getStartIndex(), index.getStopIndex(), Integer.parseInt(index.getLiterals().toString()), orderDirection);
}
+ if (astNode instanceof ExpressionSegment) {
Review comment:
@tuichenchuxin May use `expr` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org