You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/08 08:20:03 UTC

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #12939: support project subquery, in subquery and between subquery convert

strongduanmu commented on a change in pull request #12939:
URL: https://github.com/apache/shardingsphere/pull/12939#discussion_r724801433



##########
File path: shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/converter/segment/expression/ExpressionConverter.java
##########
@@ -57,6 +63,12 @@
             return new ColumnConverter().convert((ColumnSegment) segment);
         } else if (segment instanceof ExistsSubqueryExpression) {
             return new ExistsSubqueryExpressionConverter().convert((ExistsSubqueryExpression) segment);

Review comment:
       > guard clauses ?
   
   Yes, guard clauses provide better readability.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org