You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/04/03 10:35:40 UTC
[GitHub] [netbeans] vieiro opened a new pull request #2858: [NETBEANS-4619][CND] Missing license headers
vieiro opened a new pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858
Adding missing license headers in different CND modules. In my box this clears the RAT report for the CND cluster.
Some cnd modules do not support FreeMarker templates, this can be improved in the future once CND compiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
vieiro commented on pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#issuecomment-813598377
Thanks, @matthiasblaesing. Let me learn all about the surprsing "Squash and merge" magic button before hitting it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#issuecomment-814331735
We might consider the .mailmap file option as well? Should tidy up the history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
vieiro commented on pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#issuecomment-813620414
@matthiasblaesing yes, I've read your understandable concerns about this in the mailing list.
I talked with ASF Infra about this and they suggested talking to dev@community.apache.org instead (https://mail-archives.apache.org/mod_mbox/community-dev//202104.mbox/browser), I've just emailed them. Let's see what they have to say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
vieiro commented on pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#issuecomment-814373854
@matthiasblaesing The fact is that I did have a public name/email address available, but it seems this has to be public _before_ the PR is made somehow. Otherwise it won't be taken into account. So my level of trust with github's squash and merge is zero now.
@neilcsmith-net I'm not sure a .mailmap will help, but let me know how I can set it up and we can give it a run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
vieiro commented on pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#issuecomment-813064005
Hi @matthiasblaesing , thanks for your review! I've removed the license from the QT files and added a licenseinfo.xml for these files with GUI_USABILITY. Let me know if this is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#issuecomment-814385265
@vieiro maybe https://git-scm.com/docs/gitmailmap or check across ASF repos. Few projects have this set to map github private emails, etc. to the right person / email.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#issuecomment-813614884
@vieiro my personal experience: Don't trust the github facitilities for anything more complex than a plain merge. Github has the tendency to destroy history:
- If you don't expose your full name in your github settings, the author information will be broken by squash done by github
- If you don't expose at least one e-mail address in your github settings as public visible, the author information will equally be broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
vieiro commented on pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#issuecomment-814312655
D'oh! It seems the public name/email address in github has to be set _before_ the PR is done. Sorry by that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro merged pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
vieiro merged pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2858: [NETBEANS-4619][CND] Missing license headers
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2858:
URL: https://github.com/apache/netbeans/pull/2858#discussion_r606805990
##########
File path: cnd/cnd.asm/licenseinfo.xml
##########
@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<licenseinfo>
+ <fileset>
+ <!-- User templates -->
+ <file>src/org/netbeans/modules/cnd/asm/core/resources/AsmExample.s</file>
+ <file>src/org/netbeans/modules/cnd/asm/core/resources/AsmTemplate.s</file>
+ <file>src/org/netbeans/modules/cnd/asm/core/resources/InlineTemplate.il</file>
+ <license ref="Apache-2.0-ASF" />
+ <comment type="TEMPLATE_MINIMAL_IP" />
Review comment:
I think `COMMENT_UNSUPPORTED` would be more appropriate here.
##########
File path: cnd/cnd.ui/src/org/netbeans/modules/cnd/resources/templates/qt/widget.template
##########
@@ -1,3 +1,23 @@
+<!--
Review comment:
Are these user templates? If so, this looks as if the license header is taken over into the generated file. I would not add a header then.
##########
File path: cnd/cnd.ui/src/org/netbeans/modules/cnd/resources/templates/qt/resource.template
##########
@@ -1,4 +1,24 @@
<?xml version="1.0" encoding="utf-8"?>
+<!--
Review comment:
Are these user templates? If so, this looks as if the license header is taken over into the generated file. I would not add a header then.
##########
File path: cnd/cnd.ui/src/org/netbeans/modules/cnd/resources/templates/qt/dialog-nobuttons.template
##########
@@ -1,3 +1,23 @@
+<!--
Review comment:
Are these user templates? If so, this looks as if the license header is taken over into the generated file. I would not add a header then.
##########
File path: cnd/cnd.remote/tools/todo.txt
##########
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I would use the small ALv2 header here (https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available)
##########
File path: cnd/cnd.ui/src/org/netbeans/modules/cnd/resources/templates/qt/dialog-buttonsright.template
##########
@@ -1,3 +1,23 @@
+<!--
Review comment:
Are these user templates? If so, this looks as if the license header is taken over into the generated file. I would not add a header then.
##########
File path: cnd/cnd.ui/src/org/netbeans/modules/cnd/resources/templates/qt/dialog-buttonsbottom.template
##########
@@ -1,3 +1,23 @@
+<!--
Review comment:
Are these user templates? If so, this looks as if the license header is taken over into the generated file. I would not add a header then.
##########
File path: cnd/cnd.ui/src/org/netbeans/modules/cnd/resources/templates/qt/translation.template
##########
@@ -1,4 +1,24 @@
<?xml version="1.0" encoding="utf-8"?>
+<!--
Review comment:
Are these user templates? If so, this looks as if the license header is taken over into the generated file. I would not add a header then.
##########
File path: cnd/cnd.editor/licenseinfo.xml
##########
@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<licenseinfo>
+ <fileset>
+ <!-- User templates -->
+ <file>src/org/netbeans/modules/cnd/editor/resources/cplusplus/CCExample</file>
+ <file>src/org/netbeans/modules/cnd/editor/resources/cplusplus/CExample</file>
+ <file>src/org/netbeans/modules/cnd/editor/resources/cplusplus/HExample</file>
+ <file>src/org/netbeans/modules/cnd/editor/resources/fortran/FExample</file>
+ <license ref="Apache-2.0-ASF" />
+ <comment type="TEMPLATE_MINIMAL_IP" />
Review comment:
I think `GUI_USABILITY` would be more appropriate
##########
File path: cnd/cnd.ui/src/org/netbeans/modules/cnd/resources/templates/qt/mainwindow.template
##########
@@ -1,3 +1,23 @@
+<!--
Review comment:
Are these user templates? If so, this looks as if the license header is taken over into the generated file. I would not add a header then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists