You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2023/01/17 15:38:43 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1317: refactor(idl): unify the *.thrift files used by cpp and python-client
acelyc111 opened a new pull request, #1317:
URL: https://github.com/apache/incubator-pegasus/pull/1317
https://github.com/apache/incubator-pegasus/issues/1283
This patch including changes:
- remove `python-client/idl/*.thrift`
- add python related namespace to *.thrift
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1317: refactor(idl): unify the *.thrift files used by cpp and python-client
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #1317:
URL: https://github.com/apache/incubator-pegasus/pull/1317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1317: refactor(idl): unify the *.thrift files used by cpp and python-client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1317:
URL: https://github.com/apache/incubator-pegasus/pull/1317#issuecomment-1387282699
> I have a question, if the idle is changed but the client is not upgraded in time, will it cause an exception？
Usally,
> I have a question, if the idle is changed but the client is not upgraded in time, will it cause an exception？
As long as the protocol is compatiable, they will work well. AFAIK, change structure or field name without changing sequence number, add optional fields are compatiable. You can read the generated read/write functions for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on pull request #1317: refactor(idl): unify the *.thrift files used by cpp and python-client
Posted by GitBox <gi...@apache.org>.
Smityz commented on PR #1317:
URL: https://github.com/apache/incubator-pegasus/pull/1317#issuecomment-1386616142
I have a question, if the idle is changed but the client is not upgraded in time, will it cause an exception？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org