[GitHub] [tez] ayushtkn commented on a diff in pull request #169: TEZ-4357: Report url to logs in case of fetcher connection failure

[GitBox <gi...@apache.org>]

ayushtkn commented on code in PR #169:
URL: https://github.com/apache/tez/pull/169#discussion_r940610160


##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/Fetcher.java:
##########
@@ -544,8 +545,8 @@ private HostFetchResult setupConnection(Collection<InputAttemptIdentifier> attem
       } else {
         InputAttemptIdentifier firstAttempt = attempts.iterator().next();
         LOG.warn(String.format(
-            "Fetch Failure while connecting from %s to: %s:%d, attempt: %s Informing ShuffleManager: ",
-            localHostname, host, port, firstAttempt), e);
+            "Fetch Failure while connecting from %s to: %s:%d, attempt: %s, url: %s Informing ShuffleManager",
+            localHostname, host, port, firstAttempt, baseURI.toString()), e);

Review Comment:
   Do we need to call toString() here, %s can take any type & the output is always string right? BTW why aren't we using Logger format here like {} instead of String.format?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org