You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rohit Yadav <ro...@citrix.com> on 2012/09/27 15:08:56 UTC
[RBTool] Update on RBTool
I've update RBTool to make me more productive, just sharing in case you want to use it;
Get it from https://github.com/bhaisaab/RBTool and follow README file.
Changelog:
- Upgraded base fork to 0.4.2
- Creates review request based on git patch itself, no need to fill the description, summary etc. manually
- Post it from terminal, opens in browser
- Upload and strings fix
- Listing API to list pending reviews, update field checks last_update field for last 5 days, and last non-submitter comment.
Regards.
Example pending review listing:
$ rbtool-cs -l [18:32:25]
Found 28 pending review requests for cloudstack
#ID | Submitter | Branch | Reviewer | Update | Last Review by non-submitter
---------------------------------------------------------------------------------------------------------------------------------
5655 | Spark404 | master | | | alexhu-> It shouldn't use the hardcoded string but the Config.XenCheckHvm. Please correc
5806 | deeptid | 3.0.x | | | nitin->
6473 | jamshid | | | | chiradeep-> I committed this to master. I did not see JmDns in the pom.xml so I removed it f
6492 | krishna | | | | vijayvenkat->
6523 | rohityadav | master | nitin, | | nitin->
6614 | krishna | | | | alexhu-> I might be in the wrong here but none of the test methods seem to be verifying t
6702 | vijayendrabvs | master | kishan, | | kishan->
6733 | gregburd | master | | | chip.childers-> Ship It!
6781 | rohityadav | master | aprateek, alena1108, chiradeep, | | alena1108-> 1) long dcId = dest.getDataCenter().getId();
6881 | jief | | | | ke4qqq-> Jie:
6937 | satoshi-k | | | |
6941 | kawai | master, 4.0 | | | ke4qqq-> I don't see a problem with this specific change - the if statement is pretty lim
7018 | bharatk | | nitin, | | nitin-> Ship It!
7083 | pradeepso | | chip.childers, edison, | Yes | rohityadav-> Ship It!
7099 | mlsorensen | master | | Yes |
7106 | radhikap | master | ke4qqq, | Yes | jtomechak-> Some of the image file names don't match the introductory text, which makes me w
7130 | rohityadav | | aprateek, alena1108, alexhu, | Yes | alena1108-> Could you also please add warn log statement on the case when account can't be f
7168 | rohityadav | master | aprateek, kishan, nitin, alena1108, alexhu, | Yes | alexhu-> Does this need to go into 4.0?
7243 | mattycourtney | | | Yes | edison-> Ship It!
7250 | radhikap | | ke4qqq, | Yes | jtomechak-> set-global-project-resource-limits and set-per-project-resource-limits.xml shoul
7251 | sebgoa | | tsp, edison, | Yes |
7280 | radhikap | | ke4qqq, | Yes |
7285 | rohityadav | | edison, alexhu, | Yes | ke4qqq-> Why 6.2?
7288 | vijayvenkat | autoscale | devdeep, ramganesh, | Yes | devdeep-> Ship It!
7296 | vijayvenkat | autoscale | devdeep, ramganesh, | Yes | pranavs-> This patch doesn't apply cleanly because of trailing white space errors. Vijay ,
7299 | vijayvenkat | autoscale | devdeep, ramganesh, | Yes | ramganesh-> Ship It!
7302 | yichi.lu | junit-tests | | Yes |
7327 | radhikap | | ke4qqq, | Yes |
On 27-Sep-2012, at 7:27 AM, Alex Huang <Al...@citrix.com> wrote:
> That would be much appreciated.
>
> --Alex
>
>> -----Original Message-----
>> From: Chiradeep Vittal
>> Sent: Wednesday, September 26, 2012 6:30 PM
>> To: Rohit Yadav; Prasanna Santhanam
>> Cc: Alex Huang
>> Subject: FW: [AFSCS40] Drive to clear the review board
>>
>> Rohit/Prasanna
>> I know you guys did some work with the Review Board API. Currently the
>> release manager (Alex in this case) does this job manually. Can some or all
>> parts be automated using the API?
>>
>> Thanks
>> --
>> Chiradeep
>>
>> On 9/26/12 5:46 PM, "Alex Huang" <Al...@citrix.com> wrote:
>>
>>> All you have to do is look up your name and then look to see if the
>>> review has been changed from yesterday. If you haven't kept track of
>>> this daily email, then you need to look at all the items under your
>>> name and work on all of them. Please scan the list for your name.
>>>
>>> - The first column is the review #.
>>> - The second column is for who to take action.
>>> - The third column is the version this patch should go into. If it is
>>> 4+, you don't have to take action before 4.0 release.
>>> - The fourth column is if the review has changed since last push. If
>>> you're following this email daily, you should be able to just monitor
>>> this column to determine if there's new action item for you since the
>>> last push.
>>> - The fifth column is what I believe is the action needed to close out
>>> this review.
>>>
>>> Review Assign To Version Updated Action to
>> Take
>>> 5655 Hugo 4+ Respond to Review
>>> 5806 Deepti/Nitin 4 Nitin to respond to diff and commit if
>> okay to ship
>>> 6473 Jamshid 4 Mark as submit
>>> 6492 Krishna 4+ Respond to review comments
>>> 6523 Nitin 4+ Respond to Rohit
>>> 6614 Krishna 4+ Respond to review.
>>> 6702 Vijay 4 Responde to review
>>> 6733 Gregg 4 Mark as submit
>>> 6781 Alena 4+ Respond to questions
>>> 6881 Jie 4 Mark as submit
>>> 6937 Pradeep 4 Review
>>> 6941 Pradeep 4 Review and Commit
>>> 7018 Nitin 4 Commit it
>>> 7083 Chip/Edison/Rohit 4 Y Review and Commit
>>> 7099 4+
>>> 7106 Jessica T 4 Review and Commit
>>> 7130 Rohit 4 Y Resubmit with changes to review
>>> 7165 4+
>>> 7168 Kishan 4 Y Review and Commit
>>> 7187 Marcus 4+
>>> 7243 Matty Courtney 4 Y Mark as submit
>>> 7250 David Nalley 4 Y Review and Commit
>>> 7251 Prasanna 4+ Y Review and Commit
>>> 7278 4+
>>> 7280 David Nalley 4 Y Review and Commit
>>> 7284 David Nalley 4 Y Review and Commit
>>> 7285 Edison 4 Y Review and Commit
>>> 7288 4+
>>> 7296 4+
>>> 7299 4+
>>> 7302 4+
>
RE: [RBTool] Update on RBTool
Posted by Rohit Yadav <ro...@citrix.com>.
Most of these patches are specific to CloudStack and hard bound to my server for hosting the patches.
I had posted a bug so that RB won't strip git formatted patch, which was accepted and I think resolved but this will take a long time to show up on ASF infra.
Regards.
________________________________________
From: David Nalley [david@gnsa.us]
Sent: Friday, September 28, 2012 7:54 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: [RBTool] Update on RBTool
On Thu, Sep 27, 2012 at 9:08 AM, Rohit Yadav <ro...@citrix.com> wrote:
> I've update RBTool to make me more productive, just sharing in case you want to use it;
> Get it from https://github.com/bhaisaab/RBTool and follow README file.
You are upstreaming these patches right?
--David
Re: [RBTool] Update on RBTool
Posted by David Nalley <da...@gnsa.us>.
On Thu, Sep 27, 2012 at 9:08 AM, Rohit Yadav <ro...@citrix.com> wrote:
> I've update RBTool to make me more productive, just sharing in case you want to use it;
> Get it from https://github.com/bhaisaab/RBTool and follow README file.
You are upstreaming these patches right?
--David