[jira] [Commented] (DRILL-8333) Resource leak when JsonLoader is built from a stream

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617640#comment-17617640 ] 

ASF GitHub Bot commented on DRILL-8333:
---------------------------------------

jnturton opened a new pull request, #2678:
URL: https://github.com/apache/drill/pull/2678

   # [DRILL-8333](https://issues.apache.org/jira/browse/DRILL-8333): Resource leak when JsonLoader is built from a stream
   
   ## Description
   
   The JsonLoader can be built to parse from a stream, as it is by the HTTP storage plugin. Given the lifecycles of the objects involved, it is the loader that should be responsible for closing any streams that it is constructed from once JSON parsing is complete and the loader itself is closed.
   
   ## Documentation
   N/A
   
   ## Testing
   Monitor fd leakage using the lsof program on Linux while querying an HTTP plugin directly or through HTTP UDFs.
   




> Resource leak when JsonLoader is built from a stream
> ----------------------------------------------------
>
>                 Key: DRILL-8333
>                 URL: https://issues.apache.org/jira/browse/DRILL-8333
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - HTTP
>    Affects Versions: 1.20.2
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.20.3
>
>
> The JsonLoader can be built to parse from a stream, as it is by the HTTP storage plugin. Given the lifecycles of the objects involved, it is the loader that should be responsible for closing any streams passed to it once JSON parsing is complete and the loader itself is closed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)