You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/03/11 19:32:10 UTC
Review Request 44718: Replaced `const string` master constants with
`constexpr char[]`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44718/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Per style guide.
Diffs
-----
src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f
src/master/flags.cpp c1dd127109f1ba96a8f9b95f3eb99dfeb43f7d28
src/tests/flags.hpp 542f462453e41cad3b4cb8174ac59f058e625b19
Diff: https://reviews.apache.org/r/44718/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 44718: Replaced `const string` master constants
with `constexpr char[]`.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44718/#review123257
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 11, 2016, 6:32 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44718/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 6:32 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per style guide.
>
>
> Diffs
> -----
>
> src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f
> src/master/flags.cpp c1dd127109f1ba96a8f9b95f3eb99dfeb43f7d28
> src/tests/flags.hpp 542f462453e41cad3b4cb8174ac59f058e625b19
>
> Diff: https://reviews.apache.org/r/44718/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>