You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/03/01 15:24:52 UTC

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18284


Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................

IMPALA-11116: Make DESCRIBE HISTORY parameterized

The numer of snapshots can grow large, because every INSERT can create a
new one. This patch adds options to narrow down the resultset of this
statement, these are:
 - DESCRIBE HISTORY <table> FROM <ts>
 - DESCRIBE HISTORY <table> BETWEEN <ts> AND <ts>

The timestamps can be date time values and intervals as well, such as:
 - '2022-02-04 13:31:09.819'
 - 'now() - 2 days'

Testing:
 - Added e2e tests that verifies the result.
 - Added unit tests that checks the analysis.

Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
---
M common/thrift/Frontend.thrift
M docs/topics/impala_iceberg.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/query_test/test_iceberg.py
8 files changed, 262 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/18284/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18284/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:

http://gerrit.cloudera.org:8080/#/c/18284/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4957
PS2, Line 4957:         "cast('2021-08-09 15:52:45' as timestamp) - interval 2 days + interval 3 hours", iceT);
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/18284/2/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/18284/2/tests/query_test/test_iceberg.py@161
PS2, Line 161: )
flake8: E501 line too long (91 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Mar 2022 19:13:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 3:

Looks like the failure is due to test_insert_events flakiness ([IMPALA-10983|https://issues.apache.org/jira/browse/IMPALA-10983]). I am restarting the verification job.


-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 07:13:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................

IMPALA-11116: Make DESCRIBE HISTORY parameterized

The numer of snapshots can grow large, because every INSERT can create a
new one. This patch adds inclusive predicates to narrow down the
resultset of the DESCRIBE HISTORY statement, these are:
 - DESCRIBE HISTORY <table> FROM <ts>
 - DESCRIBE HISTORY <table> BETWEEN <ts> AND <ts>

The timestamps can be date time values and intervals as well, such as:
 - '2022-02-04 13:31:09.819'
 - 'now() - interval 2 days'

Testing:
 - Added e2e tests that verifies the result.
 - Added unit tests that checks the analysis.

Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
---
M common/thrift/Frontend.thrift
M docs/topics/impala_iceberg.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/query_test/test_iceberg.py
8 files changed, 286 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/18284/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................

IMPALA-11116: Make DESCRIBE HISTORY parameterized

The numer of snapshots can grow large, because every INSERT can create a
new one. This patch adds options to narrow down the resultset of this
statement, these are:
 - DESCRIBE HISTORY <table> FROM <ts>
 - DESCRIBE HISTORY <table> BETWEEN <ts> AND <ts>

The timestamps can be date time values and intervals as well, such as:
 - '2022-02-04 13:31:09.819'
 - 'now() - 2 days'

Testing:
 - Added e2e tests that verifies the result.
 - Added unit tests that checks the analysis.

Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
---
M common/thrift/Frontend.thrift
M docs/topics/impala_iceberg.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/query_test/test_iceberg.py
8 files changed, 264 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/18284/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18284/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18284/4//COMMIT_MSG@12
PS4, Line 12: <ts>
You could mention if <ts> is included in the output.


http://gerrit.cloudera.org:8080/#/c/18284/4//COMMIT_MSG@13
PS4, Line 13: <ts> AND <ts>
You should probably mention if the interval has including or excluding endpoints.


http://gerrit.cloudera.org:8080/#/c/18284/4//COMMIT_MSG@17
PS4, Line 17: 'now() - 2 days'
now() - interval 2 days


http://gerrit.cloudera.org:8080/#/c/18284/4/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/18284/4/fe/src/main/java/org/apache/impala/service/Frontend.java@1127
PS4, Line 1127:           .filter(c -> c.timestampMillis() > params.from_time)
              :           .collect(Collectors.toList());
              :     } else if (params.isSetBetween_start_time() && params.isSetBetween_end_time()) {
              :       // DESCRIBE HISTORY <table> BETWEEN <ts> AND <ts>
              :       filteredHistoryEntries = metadata.snapshotLog().stream()
              :           .filter(x -> x.timestampMillis() > params.between_start_time &&
              :               x.timestampMillis() < params.between_end_time)
Maybe we should use >= and <=? I.e. using intervals with including endpoints.



-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Mar 2022 19:09:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................

IMPALA-11116: Make DESCRIBE HISTORY parameterized

The numer of snapshots can grow large, because every INSERT can create a
new one. This patch adds options to narrow down the resultset of this
statement, these are:
 - DESCRIBE HISTORY <table> FROM <ts>
 - DESCRIBE HISTORY <table> BETWEEN <ts> AND <ts>

The timestamps can be date time values and intervals as well, such as:
 - '2022-02-04 13:31:09.819'
 - 'now() - 2 days'

Testing:
 - Added e2e tests that verifies the result.
 - Added unit tests that checks the analysis.

Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
---
M common/thrift/Frontend.thrift
M docs/topics/impala_iceberg.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/query_test/test_iceberg.py
8 files changed, 286 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/18284/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18284/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:

http://gerrit.cloudera.org:8080/#/c/18284/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4957
PS1, Line 4957:         "cast('2021-08-09 15:52:45' as timestamp) - interval 2 days + interval 3 hours", iceT);
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/18284/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/18284/1/tests/query_test/test_iceberg.py@250
PS1, Line 250: d
flake8: F811 redefinition of unused 'test_describe_history' from line 102


http://gerrit.cloudera.org:8080/#/c/18284/1/tests/query_test/test_iceberg.py@287
PS1, Line 287: )
flake8: E501 line too long (91 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 15:25:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7898/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 07:13:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................

IMPALA-11116: Make DESCRIBE HISTORY parameterized

The numer of snapshots can grow large, because every INSERT can create a
new one. This patch adds inclusive predicates to narrow down the
resultset of the DESCRIBE HISTORY statement, these are:
 - DESCRIBE HISTORY <table> FROM <ts>
 - DESCRIBE HISTORY <table> BETWEEN <ts> AND <ts>

The timestamps can be date time values and intervals as well, such as:
 - '2022-02-04 13:31:09.819'
 - 'now() - interval 2 days'

Testing:
 - Added e2e tests that verifies the result.
 - Added unit tests that checks the analysis.

Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Reviewed-on: http://gerrit.cloudera.org:8080/18284
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M common/thrift/Frontend.thrift
M docs/topics/impala_iceberg.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/query_test/test_iceberg.py
8 files changed, 286 insertions(+), 24 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Zoltan Borok-Nagy: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 6
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................

IMPALA-11116: Make DESCRIBE HISTORY parameterized

The numer of snapshots can grow large, because every INSERT can create a
new one. This patch adds options to narrow down the resultset of this
statement, these are:
 - DESCRIBE HISTORY <table> FROM <ts>
 - DESCRIBE HISTORY <table> BETWEEN <ts> AND <ts>

The timestamps can be date time values and intervals as well, such as:
 - '2022-02-04 13:31:09.819'
 - 'now() - 2 days'

Testing:
 - Added e2e tests that verifies the result.
 - Added unit tests that checks the analysis.

Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
---
M common/thrift/Frontend.thrift
M docs/topics/impala_iceberg.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/query_test/test_iceberg.py
8 files changed, 262 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/18284/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7895/


-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 04:02:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 12:05:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 3:

(6 comments)

Found a few nits, otherwise the change LGTM!

http://gerrit.cloudera.org:8080/#/c/18284/3/fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
File fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java:

http://gerrit.cloudera.org:8080/#/c/18284/3/fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java@70
PS3, Line 70: miliseconds
nit: milliseconds, also in later comments.


http://gerrit.cloudera.org:8080/#/c/18284/3/fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java@71
PS3, Line 71: fromMilis_
nit: fromMillis_;

The same goes for between start and end.


http://gerrit.cloudera.org:8080/#/c/18284/3/fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java@130
PS3, Line 130:     expr.analyze(analyzer);
nit: + indent


http://gerrit.cloudera.org:8080/#/c/18284/3/fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java@143
PS3, Line 143: _
nit: unnecessary underscore for local variable


http://gerrit.cloudera.org:8080/#/c/18284/3/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/18284/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1122
PS3, Line 1122: fintered
filtered


http://gerrit.cloudera.org:8080/#/c/18284/3/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/18284/3/tests/query_test/test_iceberg.py@157
PS3, Line 157:     # We are setting the TIMEZONE query option in this test, so let's create a local
             :     # impala client.
We don't set the timezone in this test.



-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 12:20:41 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11116: Make DESCRIBE HISTORY parameterized

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18284 )

Change subject: IMPALA-11116: Make DESCRIBE HISTORY parameterized
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7895/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifead0d33f22069005bfd623460f4af1ff197cc0e
Gerrit-Change-Number: 18284
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Mar 2022 22:41:26 +0000
Gerrit-HasComments: No