You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "liusheng (Code Review)" <ge...@cloudera.org> on 2020/05/07 02:54:06 UTC
[kudu-CR] KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
liusheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15874
Change subject: KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
......................................................................
KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
This change importted the 'sse2neon.h' file from [1] to adapt the SSE
instrisics support in Kudu for specific ARM64/aarch64 platform. Now Kudu
use SSE4.2 instrisics which is not supported on aaarch64 platform. This
file provides a simple API translation layer between SSE intrinsics to
their corresponding Arm/Aarch64 NEON versions
[1] https://github.com/DLTcollab/sse2neon/blob/master/sse2neon.h
Change-Id: I7af0b1ce17d6a3a3d87de793ba3973c393dc2088
---
A src/kudu/util/sse2neon.h
1 file changed, 3,285 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/15874/1
--
To view, visit http://gerrit.cloudera.org:8080/15874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7af0b1ce17d6a3a3d87de793ba3973c393dc2088
Gerrit-Change-Number: 15874
Gerrit-PatchSet: 1
Gerrit-Owner: liusheng <li...@gmail.com>
[kudu-CR] KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15874 )
Change subject: KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7af0b1ce17d6a3a3d87de793ba3973c393dc2088
Gerrit-Change-Number: 15874
Gerrit-PatchSet: 2
Gerrit-Owner: liusheng <li...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <he...@apache.org>
Gerrit-Comment-Date: Fri, 08 May 2020 16:06:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15874 )
Change subject: KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
......................................................................
KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
This change importted the 'sse2neon.h' file from [1] to adapt the SSE
instrisics support in Kudu for specific ARM64/aarch64 platform. Now Kudu
use SSE4.2 instrisics which is not supported on aaarch64 platform. This
file provides a simple API translation layer between SSE intrinsics to
their corresponding Arm/Aarch64 NEON versions
[1] https://github.com/DLTcollab/sse2neon/blob/master/sse2neon.h
Change-Id: I7af0b1ce17d6a3a3d87de793ba3973c393dc2088
Reviewed-on: http://gerrit.cloudera.org:8080/15874
Reviewed-by: helifu <he...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/char_util.cc
A src/kudu/util/sse2neon.h
2 files changed, 3,289 insertions(+), 0 deletions(-)
Approvals:
helifu: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7af0b1ce17d6a3a3d87de793ba3973c393dc2088
Gerrit-Change-Number: 15874
Gerrit-PatchSet: 3
Gerrit-Owner: liusheng <li...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <he...@apache.org>
[kudu-CR] KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
Posted by "helifu (Code Review)" <ge...@cloudera.org>.
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15874 )
Change subject: KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
......................................................................
Patch Set 2: Code-Review+1
LGTM :)
--
To view, visit http://gerrit.cloudera.org:8080/15874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7af0b1ce17d6a3a3d87de793ba3973c393dc2088
Gerrit-Change-Number: 15874
Gerrit-PatchSet: 2
Gerrit-Owner: liusheng <li...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <he...@apache.org>
Gerrit-Comment-Date: Fri, 08 May 2020 09:06:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
Posted by "liusheng (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15874
to look at the new patch set (#2).
Change subject: KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
......................................................................
KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64
This change importted the 'sse2neon.h' file from [1] to adapt the SSE
instrisics support in Kudu for specific ARM64/aarch64 platform. Now Kudu
use SSE4.2 instrisics which is not supported on aaarch64 platform. This
file provides a simple API translation layer between SSE intrinsics to
their corresponding Arm/Aarch64 NEON versions
[1] https://github.com/DLTcollab/sse2neon/blob/master/sse2neon.h
Change-Id: I7af0b1ce17d6a3a3d87de793ba3973c393dc2088
---
M src/kudu/util/char_util.cc
A src/kudu/util/sse2neon.h
2 files changed, 3,289 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/15874/2
--
To view, visit http://gerrit.cloudera.org:8080/15874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7af0b1ce17d6a3a3d87de793ba3973c393dc2088
Gerrit-Change-Number: 15874
Gerrit-PatchSet: 2
Gerrit-Owner: liusheng <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)