You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/14 07:24:41 UTC

[GitHub] [iotdb] MarcosZyk commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes

MarcosZyk commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r825649905



##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -1762,7 +1762,9 @@ public TSStatus createAlignedTimeseries(TSCreateAlignedTimeseriesReq req) {
               dataTypes,
               encodings,
               compressors,
-              req.measurementAlias);
+              req.measurementAlias,
+              req.tagsList,
+              req.attributesList);

Review comment:
       Please consider the compatibility with the interface of old version. May add a new interface to support tag/attribute is a better solution.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org