You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/11 22:44:28 UTC

[GitHub] [kafka] hachikuji opened a new pull request #9166: KAFKA-10388; Fix struct conversion logic for tagged structures

hachikuji opened a new pull request #9166:
URL: https://github.com/apache/kafka/pull/9166


   The message generator was missing conversion logic for tagged structures. This led to casting errors when either `fromStruct` or `toStruct` were invoked. In the process of fixing this, I also found that tagged byte arrays were missing null checks. I fixed this here so that the improved tests passed. 
   
   I noticed as well that zero-copy byte arrays were not handled, but that can be addressed separately (https://issues.apache.org/jira/browse/KAFKA-10389).
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #9166: KAFKA-10388; Fix struct conversion logic for tagged structures

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #9166:
URL: https://github.com/apache/kafka/pull/9166


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on pull request #9166: KAFKA-10388; Fix struct conversion logic for tagged structures

Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #9166:
URL: https://github.com/apache/kafka/pull/9166#issuecomment-672347559


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe commented on pull request #9166: KAFKA-10388; Fix struct conversion logic for tagged structures

Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9166:
URL: https://github.com/apache/kafka/pull/9166#issuecomment-672338336


   Thanks.  This is one of those rare PRs where I really don't have any comments on how the code could be better.
   
   I do think we should do a round-trip test with the JSON converter as well, but that's out of scope for this change.
   
   Also, I should note that I am working on separating out the JSON stuff into a helper class.  I think we may want to do this for the Struct stuff as well.  Or at least provide some option to not generate the Struct stuff in cases where we don't need the legacy methods (like in the KIP-500 generated messages).  But again, that's out of scope for this change.
   
   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org