You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2021/04/03 15:09:00 UTC

[jira] [Resolved] (HBASE-25723) Temporarily remove the trace support for RegionScanner.next

     [ https://issues.apache.org/jira/browse/HBASE-25723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-25723.
-------------------------------
    Fix Version/s: HBASE-22120
     Hadoop Flags: Reviewed
       Resolution: Fixed

Merged to branch HBASE-22120.

Thanks [~vjasani] for reviewing.

> Temporarily remove the trace support for RegionScanner.next
> -----------------------------------------------------------
>
>                 Key: HBASE-25723
>                 URL: https://issues.apache.org/jira/browse/HBASE-25723
>             Project: HBase
>          Issue Type: Sub-task
>          Components: scan, tracing
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: HBASE-22120
>
>
> Please see the test result in HBASE-25658, tracing RegionScanner.next could lead to a 6% performance downgrading even if we do not enable tracing.
> I think the problem here is that, a single scan rpc call could lead to a bunch of RegionScanner.next. So if trace is enabled, there will be much more performance impact as we need to store a bunch of spans(maybe this could be limited by some parameters?).
> Anyway, let's remove it for now to land the basic trace framework first. Can improve later.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)