[GitHub] [thrift] fishy commented on pull request #2824: Use Enum or string in Struct serialization/deserialization for py:enum gen code

["fishy (via GitHub)" <gi...@apache.org>]

fishy commented on PR #2824:
URL: https://github.com/apache/thrift/pull/2824#issuecomment-1613531692

   does this only affect how the python lib is called or does this actually affect how the serialized binary blob (aka wire protocol) would look like?
   
   if this affects how the binary blob would look like, then this most certainly would break cross-test. we currently don't run cross-tests in github actions because the lib-java-kotlin test is broken, you can temporarily remove that as the dependency of cross-test in your PR to make it run cross test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org