[GitHub] [nifi] dan-s1 commented on a diff in pull request #7221: [NIFI-11511] Added Provenance route events for all relationships in ValidateJson.

["dan-s1 (via GitHub)" <gi...@apache.org>]

dan-s1 commented on code in PR #7221:
URL: https://github.com/apache/nifi/pull/7221#discussion_r1182625081


##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestValidateJson.java:
##########
@@ -109,6 +117,8 @@ void testPatternSchemaCheck() {
         runner.assertTransferCount(ValidateJson.REL_VALID, 0);
 
         assertValidationErrors(ValidateJson.REL_INVALID, true);
+        assertEquals(1, runner.getProvenanceEvents().size());
+        assertEquals(ProvenanceEventType.ROUTE, runner.getProvenanceEvents().get(0).getEventType());

Review Comment:
   @MikeThomsen Thank you so much for reviewing and merging my code so quickly. I did have a question regarding the number of Provenance events with the invalid relationship. There is an attribute created when JSON is invalid which previously resulted in a Provenance modified attribute event. Now that I added the Provenance route event the modified attribute event is no longer there as this unit test indicates there is only one resulting Provenance event. Why is that so?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org