You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2018/02/22 05:45:00 UTC

Review Request 65747: RANGER-1981: Error in constructing base path for UI API when accessing Atlas via knox proxy without "/" at the end

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65747/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-1981
    https://issues.apache.org/jira/browse/RANGER-1981


Repository: ranger


Description
-------

1.Enabled knox proxy for ranger.
2.Accessed ranger UI via proxy using https://knox_gateway:8443/gateway/ui/ranger
3.Provided admin username and password and logged into ranger
4.Now, opened another tab in browser with URL

UI is loaded without data because API path is not formed properly.

If the URL is accessed with "/" at the end, logs in as admin user and all operations work fine.


Diffs
-----

  security-admin/src/main/webapp/scripts/modules/RestCsrf.js c201c72 


Diff: https://reviews.apache.org/r/65747/diff/1/


Testing
-------

Covered test cases :
1.By removing '/' in front of ranger (https://<localhost>:8443/gateway/ui/ranger)
2.By keeping '/' in front of ranger (https://<localhost>:8443/gateway/ui/ranger/)
3.Tested with KNOX SSO url.
4.Tested that when we hit KNOX proxy URL we get redirected to KNOX SSO.
5.By removing '/' in front of ranger after navigating to the different page.


Thanks,

Nitin Galave


Re: Review Request 65747: RANGER-1981: Error in constructing base path for UI API when accessing Atlas via knox proxy without "/" at the end

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65747/#review198098
-----------------------------------------------------------


Ship it!




Ship It!

- Gautam Borad


On Feb. 22, 2018, 5:44 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65747/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 5:44 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1981
>     https://issues.apache.org/jira/browse/RANGER-1981
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1.Enabled knox proxy for ranger.
> 2.Accessed ranger UI via proxy using https://knox_gateway:8443/gateway/ui/ranger
> 3.Provided admin username and password and logged into ranger
> 4.Now, opened another tab in browser with URL
> 
> UI is loaded without data because API path is not formed properly.
> 
> If the URL is accessed with "/" at the end, logs in as admin user and all operations work fine.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/modules/RestCsrf.js c201c72 
> 
> 
> Diff: https://reviews.apache.org/r/65747/diff/1/
> 
> 
> Testing
> -------
> 
> Covered test cases :
> 1.By removing '/' in front of ranger (https://<localhost>:8443/gateway/ui/ranger)
> 2.By keeping '/' in front of ranger (https://<localhost>:8443/gateway/ui/ranger/)
> 3.Tested with KNOX SSO url.
> 4.Tested that when we hit KNOX proxy URL we get redirected to KNOX SSO.
> 5.By removing '/' in front of ranger after navigating to the different page.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 65747: RANGER-1981: Error in constructing base path for UI API when accessing Atlas via knox proxy without "/" at the end

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65747/#review198102
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Feb. 22, 2018, 5:44 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65747/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 5:44 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1981
>     https://issues.apache.org/jira/browse/RANGER-1981
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1.Enabled knox proxy for ranger.
> 2.Accessed ranger UI via proxy using https://knox_gateway:8443/gateway/ui/ranger
> 3.Provided admin username and password and logged into ranger
> 4.Now, opened another tab in browser with URL
> 
> UI is loaded without data because API path is not formed properly.
> 
> If the URL is accessed with "/" at the end, logs in as admin user and all operations work fine.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/modules/RestCsrf.js c201c72 
> 
> 
> Diff: https://reviews.apache.org/r/65747/diff/1/
> 
> 
> Testing
> -------
> 
> Covered test cases :
> 1.By removing '/' in front of ranger (https://<localhost>:8443/gateway/ui/ranger)
> 2.By keeping '/' in front of ranger (https://<localhost>:8443/gateway/ui/ranger/)
> 3.Tested with KNOX SSO url.
> 4.Tested that when we hit KNOX proxy URL we get redirected to KNOX SSO.
> 5.By removing '/' in front of ranger after navigating to the different page.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>