You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by arunmahadevan <gi...@git.apache.org> on 2015/08/04 10:47:30 UTC

[GitHub] storm pull request: Storm-Kafka trident topology example

GitHub user arunmahadevan opened a pull request:

    https://github.com/apache/storm/pull/666

    Storm-Kafka trident topology example

    A sample word count trident topology to illustrate the use of Transactional Kafka spout and Kafka bolt. This has the following components
    
    1. KafkaBolt that receives random sentences from RandomSentenceSpout and publishes the sentences to a kafka "test" topic.
    2. TransactionalTridentKafkaSpout that consumes sentences from the "test" topic, splits it into words, aggregates and stores the word count in a MemoryMapState.
    3. DRPC query that returns the word counts by querying the trident state (MemoryMapState).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arunmahadevan/storm storm-kafka-example

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #666
    
----
commit 287718c8bc0f8b51ca89de4f62fcb6710d525992
Author: Arun Mahadevan <ai...@hortonworks.com>
Date:   2015-08-04T08:36:45Z

    Storm-Kafka trident topology example

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/666#issuecomment-131276460
  
    Other things look fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:

    https://github.com/apache/storm/pull/666#issuecomment-129299716
  
    @harshach added a new jira issue STORM-975



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:

    https://github.com/apache/storm/pull/666#issuecomment-129708021
  
    @harshach done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/666#issuecomment-130404466
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/666#discussion_r37130096
  
    --- Diff: examples/storm-starter/src/jvm/storm/starter/trident/TridentKafkaWordCount.java ---
    @@ -0,0 +1,208 @@
    +package storm.starter.trident;
    --- End diff --
    
    @arunmahadevan Please add Apache License comments here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/666#issuecomment-129559848
  
    @arunmahadevan can you upmerge this with master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/666#discussion_r37133083
  
    --- Diff: examples/storm-starter/src/jvm/storm/starter/trident/TridentKafkaWordCount.java ---
    @@ -0,0 +1,208 @@
    +package storm.starter.trident;
    --- End diff --
    
    @HeartSaVioR done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm-Kafka trident topology example

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/666#issuecomment-129284763
  
    @arunmahadevan can you please file a jira and send a pr with jira number in it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm-Kafka trident topology example

Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/666#discussion_r36173014
  
    --- Diff: examples/storm-starter/pom.xml ---
    @@ -96,6 +96,12 @@
           <groupId>com.google.guava</groupId>
           <artifactId>guava</artifactId>
         </dependency>
    +    <dependency>
    +      <groupId>org.apache.storm</groupId>
    +      <artifactId>storm-kafka</artifactId>
    --- End diff --
    
    @caofangkun thanks. Fixed the dependencies and changed the order.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm-Kafka trident topology example

Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on a diff in the pull request:

    https://github.com/apache/storm/pull/666#discussion_r36169516
  
    --- Diff: examples/storm-starter/pom.xml ---
    @@ -96,6 +96,12 @@
           <groupId>com.google.guava</groupId>
           <artifactId>guava</artifactId>
         </dependency>
    +    <dependency>
    +      <groupId>org.apache.storm</groupId>
    +      <artifactId>storm-kafka</artifactId>
    --- End diff --
    
    should move ``` <module>examples/storm-starter</module>``` in [pom.xml](https://github.com/apache/storm/blob/master/pom.xml#L164) after ```<module>external/flux</module>```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/666


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/666#issuecomment-131786154
  
    +1. Tested on local machine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---