You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/18 06:03:00 UTC
[jira] [Commented] (AIRFLOW-3206) More neutral language regarding
Copyleft in installation instructions
[ https://issues.apache.org/jira/browse/AIRFLOW-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723738#comment-16723738 ]
ASF GitHub Bot commented on AIRFLOW-3206:
-----------------------------------------
stale[bot] closed pull request #4055: [AIRFLOW-3206] neutral and clear GPL dependency notice
URL: https://github.com/apache/incubator-airflow/pull/4055
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/setup.py b/setup.py
index b1376bb5bb..a85b3e9581 100644
--- a/setup.py
+++ b/setup.py
@@ -46,11 +46,13 @@ def verify_gpl_dependency():
os.environ["SLUGIFY_USES_TEXT_UNIDECODE"] = "yes"
if not os.getenv("AIRFLOW_GPL_UNIDECODE") and not os.getenv("SLUGIFY_USES_TEXT_UNIDECODE") == "yes":
- raise RuntimeError("By default one of Airflow's dependencies installs a GPL "
- "dependency (unidecode). To avoid this dependency set "
- "SLUGIFY_USES_TEXT_UNIDECODE=yes in your environment when you "
- "install or upgrade Airflow. To force installing the GPL "
- "version set AIRFLOW_GPL_UNIDECODE")
+ raise RuntimeError(
+ "By default, one of Airflow's dependencies (unidecode) is GPL licensed .\n"
+ "In order to proceed with installation, "
+ "you will need to set one of the following environment variables:\n"
+ "To disallow the dependency, export SLUGIFY_USES_TEXT_UNIDECODE=yes.\n"
+ "To allow the dependency, export AIRFLOW_GPL_UNIDECODE=yes.\n"
+ "Once either environment variable is set, you may proceed with installation.")
class Tox(TestCommand):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> More neutral language regarding Copyleft in installation instructions
> ---------------------------------------------------------------------
>
> Key: AIRFLOW-3206
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3206
> Project: Apache Airflow
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 1.10.0
> Reporter: Brylie Christopher Oxley
> Assignee: Brylie Christopher Oxley
> Priority: Trivial
> Labels: newbie
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> When installing Airflow, the user must set an environment variable to explicitly _allow_ or _disallow_ the installation of a GPL dependency. The text of the error message is somewhat difficult to read, and seems biased against the GPL dependency.
> h2. Task
> * add proper line breaks to GPL dependency notice, for improved readability
> * use neutral language _allow_ and _disallow_ (as opposed to 'force')
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)