[GitHub] [ant] bodewig commented on pull request #126: support to access local properties via propertyset

[GitBox <gi...@apache.org>]

bodewig commented on pull request #126:
URL: https://github.com/apache/ant/pull/126#issuecomment-667667624


   By returning `false` from `LocalPropertyStack`'s `setNew` you create a copy of the local property inside of the project properties themselves. I can see you do this because there is no way to enumerate all properties that are in scope - there are a few comments in `PropertyHelper` that indicate we have been aware of the problem back when we worked on Ant 1.8.0.
   
   What would probably be cleaner was to finally introduce a new `PropertyEnumerator` delegate along with new methods left and right and allow `PropertySet` to use that. I'll sketch this in a branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org