You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/03 08:19:20 UTC

[GitHub] [flink] aljoscha opened a new pull request #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

aljoscha opened a new pull request #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625
 
 
   We instead use asm-7, which is normally not available in the Flink 1.9.x
   line, as a test dependency.
   
   cc @zentol 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625#issuecomment-608312573
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f63ceb4c101488d6df12f0314f30de2ef6aca411",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158161668",
       "triggerID" : "f63ceb4c101488d6df12f0314f30de2ef6aca411",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f63ceb4c101488d6df12f0314f30de2ef6aca411 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158161668) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625#issuecomment-608312573
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f63ceb4c101488d6df12f0314f30de2ef6aca411",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158161668",
       "triggerID" : "f63ceb4c101488d6df12f0314f30de2ef6aca411",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f63ceb4c101488d6df12f0314f30de2ef6aca411 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158161668) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625#issuecomment-608358285
 
 
   True about the filter, it's just a more conservative approach overall.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha closed pull request #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625#issuecomment-609731423
 
 
   Thanks for the review!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625#issuecomment-608299030
 
 
   I copied the code from the master branch, so there's also a small fix included for https://issues.apache.org/jira/browse/FLINK-15739 (the additional "filter" line). I can remove that, though, if you want.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625#issuecomment-608299559
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f63ceb4c101488d6df12f0314f30de2ef6aca411 (Fri Apr 03 08:21:58 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11625: [FLINK-16954] Don't use JDK11 APIs in ClassRelocator
URL: https://github.com/apache/flink/pull/11625#issuecomment-608312573
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f63ceb4c101488d6df12f0314f30de2ef6aca411",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f63ceb4c101488d6df12f0314f30de2ef6aca411",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f63ceb4c101488d6df12f0314f30de2ef6aca411 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services