You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2019/01/11 05:13:09 UTC
Review Request 69712: Added a CNI reboot test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69712/
-----------------------------------------------------------
Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian Zhang.
Bugs: MESOS-9518
https://issues.apache.org/jira/browse/MESOS-9518
Repository: mesos
Description
-------
This test verifies that CNI DEL is properly called even after the agent
host is rebooted, assuming `--network_cni_root_dir_persist` flag is set
to true.
Diffs
-----
src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
Diff: https://reviews.apache.org/r/69712/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 69712: Added a CNI reboot test.
Posted by Deepak Goel <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69712/#review211898
-----------------------------------------------------------
Ship it!
Ship It!
- Deepak Goel
On Jan. 11, 2019, 6:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69712/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 6:49 p.m.)
>
>
> Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9518
> https://issues.apache.org/jira/browse/MESOS-9518
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that CNI DEL is properly called even after the agent
> host is rebooted, assuming `--network_cni_root_dir_persist` flag is set
> to true.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
>
>
> Diff: https://reviews.apache.org/r/69712/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 69712: Added a CNI reboot test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69712/
-----------------------------------------------------------
(Updated Jan. 11, 2019, 6:49 p.m.)
Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian Zhang.
Bugs: MESOS-9518
https://issues.apache.org/jira/browse/MESOS-9518
Repository: mesos
Description
-------
This test verifies that CNI DEL is properly called even after the agent
host is rebooted, assuming `--network_cni_root_dir_persist` flag is set
to true.
Diffs (updated)
-----
src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
Diff: https://reviews.apache.org/r/69712/diff/3/
Changes: https://reviews.apache.org/r/69712/diff/2-3/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 69712: Added a CNI reboot test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69712/
-----------------------------------------------------------
(Updated Jan. 11, 2019, 6:09 p.m.)
Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian Zhang.
Bugs: MESOS-9518
https://issues.apache.org/jira/browse/MESOS-9518
Repository: mesos
Description
-------
This test verifies that CNI DEL is properly called even after the agent
host is rebooted, assuming `--network_cni_root_dir_persist` flag is set
to true.
Diffs (updated)
-----
src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
Diff: https://reviews.apache.org/r/69712/diff/2/
Changes: https://reviews.apache.org/r/69712/diff/1-2/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 69712: Added a CNI reboot test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69712/#review211856
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69706', '69710', '69711', '69712']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2754/mesos-review-69712
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2754/mesos-review-69712/logs/mesos-tests.log):
```
I0111 06:06:37.088624 13492 containerizer.cpp:2975] Container bc085dee-9f66-4f61-806c-8c6b9c756611 has exited
I0111 06:06:37.118649 9304 master.cpp:1111] Master [ OK ] HealthCheckTest.HealthyTaskViaTCP (1191 ms)
[----------] 12 tests from HealthCheckTest (17437 ms total)
[----------] 3 tests from DockerContainerizerHealthCheckTest
[ RUN ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthyTask
terminating
I0111 06:06:37.119628 13840 hierarchical.cpp:644] Removed agent bc64bbf3-846e-4e54-aa84-041d7185dc57-S0
W0111 06:06:37.174670 9304 health_check_tests.cpp:2116] Pulling akagup/nano-admin, akagup/https-server and akagup/https-server. This might take a while...
I0111 06:06:37.412647 9304 cluster.cpp:174] Creating default 'local' authorizer
I0111 06:06:37.420631 13840 master.cpp:416] Master e70d2911-8c8b-4f0f-b686-31657aef2249 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) started on 192.10.1.6:59861
I0111 06:06:37.420631 13840 master.cpp:419] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="hierarchical" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authentication_v0_timeout="15secs" --authenticators="crammd5" --authorizers="local" --credentials="C:\Jenkins\workspace\mesos-reviewbot-testing\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_operator_event_stream_subscribers="1000" --max_unreachable_tasks_per_framework="1000" --mem
ory_profiling="false" --min_allocatable_resources="cpus:0.01|mem:32" --port="5050" --publish_per_framework_metrics="true" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memory" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --require_agent_domain="false" --role_sorter="drf" --root_submissions="true" --version="false" --webui_dir="/webui" --work_dir="C:\Jenkins\workspace\mesos-reviewbot-testing\master" --zk_session_timeout="10secs"
I0111 06:06:37.422675 13840 master.cpp:468] Master only allowing authenticated frameworks to register
I0111 06:06:37.422675 13840 master.cpp:474] Master only allowing authenticated agents to register
I0111 06:06:37.422675 13840 master.cpp:480] Master only allowing authenticated HTTP frameworks to register
I0111 06:06:37.422675 13840 credentials.hpp:37] Loading credentials for authentication from 'C:\Jenkins\workspace\mesos-reviewbot-testing\credentials'
I0111 06:06:37.423686 13840 master.cpp:524] Using default 'crammd5' authenticator
I0111 06:06:37.424644 13840 http.cpp:965] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I0111 06:06:37.424644 13840 http.cpp:965] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I0111 06:06:37.425648 13840 http.cpp:965] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I0111 06:06:37.425648 13840 master.cpp:605] Authorization enabled
I0111 06:06:37.435660 8228 master.cpp:2085] Elected as the leading master!
I0111 06:06:37.435660 8228 master.cpp:1640] Recovering from registrar
I0111 06:06:37.436669 8240 registrar.cpp:383] Successfully fetched the registry (0B) in 1.008896ms
I0111 06:06:37.436669 8240 registrar.cpp:487] Applied 1 operations in 0ns; attempting to update the registry
I0111 06:06:37.437690 13492 registrar.cpp:544] Successfully updated the registry in 1.02144ms
I0111 06:06:37.438663 13492 registrar.cpp:416] Successfully recovered registrar
I0111 06:06:37.439663 14180 master.cpp:1754] Recovered 0 agents from the registry (235B); allowing 10mins for agents to reregister
Assertion failed: isSome(), file d:\dcos\mesos\mesos\3rdparty\stout\include\stout\option.hpp, line 119
```
- Mesos Reviewbot Windows
On Jan. 11, 2019, 5:13 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69712/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 5:13 a.m.)
>
>
> Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9518
> https://issues.apache.org/jira/browse/MESOS-9518
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that CNI DEL is properly called even after the agent
> host is rebooted, assuming `--network_cni_root_dir_persist` flag is set
> to true.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
>
>
> Diff: https://reviews.apache.org/r/69712/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 69712: Added a CNI reboot test.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 11, 2019, 9:38 a.m., Qian Zhang wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Lines 2612-2613 (patched)
> > <https://reviews.apache.org/r/69712/diff/1/?file=2119174#file2119174line2612>
> >
> > `%s` is the total size, should we check the device ID instead?
err, this is unforntate, this %s is used to print %d. But I figured out a better way to use `%%d`
> On Jan. 11, 2019, 9:38 a.m., Qian Zhang wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Lines 2763-2764 (patched)
> > <https://reviews.apache.org/r/69712/diff/1/?file=2119174#file2119174line2763>
> >
> > This comment seems not correct.
GOod catch! copy paste error :facepalm
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69712/#review211871
-----------------------------------------------------------
On Jan. 11, 2019, 5:13 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69712/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 5:13 a.m.)
>
>
> Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9518
> https://issues.apache.org/jira/browse/MESOS-9518
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that CNI DEL is properly called even after the agent
> host is rebooted, assuming `--network_cni_root_dir_persist` flag is set
> to true.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
>
>
> Diff: https://reviews.apache.org/r/69712/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 69712: Added a CNI reboot test.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69712/#review211871
-----------------------------------------------------------
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2612-2613 (patched)
<https://reviews.apache.org/r/69712/#comment297452>
`%s` is the total size, should we check the device ID instead?
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2621-2622 (patched)
<https://reviews.apache.org/r/69712/#comment297451>
Why do we need these?
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2722 (patched)
<https://reviews.apache.org/r/69712/#comment297453>
s/1u/1/ since what `containers_size` returns is `int`.
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2763-2764 (patched)
<https://reviews.apache.org/r/69712/#comment297454>
This comment seems not correct.
- Qian Zhang
On Jan. 11, 2019, 1:13 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69712/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 1:13 p.m.)
>
>
> Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9518
> https://issues.apache.org/jira/browse/MESOS-9518
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that CNI DEL is properly called even after the agent
> host is rebooted, assuming `--network_cni_root_dir_persist` flag is set
> to true.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
>
>
> Diff: https://reviews.apache.org/r/69712/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>