You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by robertamarton <gi...@git.apache.org> on 2015/07/08 23:52:23 UTC
[GitHub] incubator-trafodion pull request: Privilege manager fixes for 1438...
GitHub user robertamarton opened a pull request:
https://github.com/apache/incubator-trafodion/pull/23
Privilege manager fixes for 1438896 and 1465356
1438896: Internal error during create or replace view
The objectUID check when getting privilege information was not correct.
1465356: Revoke privilege from role returns dependent object error
There is a check in mainline revoke code to determine if the object type is a
view and if the SELECT privilege is no longer applicable. If so, then the
dependent error is returned. However, this code is incorrect and actually the
correct code exists in the gatherViewPrivileges method. The view check has been
removed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertamarton/incubator-trafodion fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 74ebecd3141b4d5856c633466244fb282bdf2049
Author: Roberta Marton <ro...@esgyn.com>
Date: 2015-07-08T21:46:14Z
Privilege manager fixes for 1438896 and 1465356
1438896: Internal error during create or replace view
The objectUID check when getting privilege information was not correct.
1465356: Revoke privilege from role returns dependent object error
There is a check in mainline revoke code to determine if the object type is a
view and if the SELECT privilege is no longer applicable. If so, then the
dependent error is returned. However, this code is incorrect and actually the
correct code exists in the gatherViewPrivileges method. The view check has been
removed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Privilege manager fixes for 1438...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---