You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/04/21 18:25:06 UTC

Review Request 46497: Added authentication to the '/profiler/*' endpoints.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/
-----------------------------------------------------------

Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-4902
    https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
-------

Added authentication to the '/profiler/*' endpoints.


Diffs
-----

  3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab 
  3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
  3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 

Diff: https://reviews.apache.org/r/46497/diff/


Testing
-------

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

Posted by Greg Mann <gr...@mesosphere.io>.

> On April 25, 2016, 12:37 p.m., Alexander Rojas wrote:
> >

Whoops! Thanks Alexander :-)


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/#review130395
-----------------------------------------------------------


On April 25, 2016, 2:02 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46497/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 2:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to the '/profiler/*' endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab 
>   3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
>   3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 
> 
> Diff: https://reviews.apache.org/r/46497/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX. The endpoints were also tested by configuring with `../configure --enable-perftools`, and then hitting `/profiler/start` and `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER` environment variable set to 1.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/#review130395
-----------------------------------------------------------




3rdparty/libprocess/include/process/profiler.hpp (line 71)
<https://reviews.apache.org/r/46497/#comment194131>

    s/authenticationRealm/principal/



3rdparty/libprocess/include/process/profiler.hpp (line 78)
<https://reviews.apache.org/r/46497/#comment194132>

    s/authenticationRealm/principal/



3rdparty/libprocess/src/profiler.cpp (line 61)
<https://reviews.apache.org/r/46497/#comment194133>

    s/authenticationRealm//*principal*//



3rdparty/libprocess/src/profiler.cpp (line 106)
<https://reviews.apache.org/r/46497/#comment194134>

    s/authenticationRealm//*principal*//


- Alexander Rojas


On April 21, 2016, 6:25 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46497/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 6:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to the '/profiler/*' endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab 
>   3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
>   3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 
> 
> Diff: https://reviews.apache.org/r/46497/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/#review129915
-----------------------------------------------------------



Bad patch!

Reviews applied: [46497, 46462, 46461]

Failed command: ./support/apply-review.sh -n -r 46497

Error:
2016-04-21 16:36:40 URL:https://reviews.apache.org/r/46497/diff/raw/ [3832/3832] -> "46497.patch" [1]
error: patch failed: 3rdparty/libprocess/src/process.cpp:979
error: 3rdparty/libprocess/src/process.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12654/console

- Mesos ReviewBot


On April 21, 2016, 4:25 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46497/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 4:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to the '/profiler/*' endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab 
>   3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
>   3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 
> 
> Diff: https://reviews.apache.org/r/46497/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/#review130415
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rojas


On April 25, 2016, 4:02 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46497/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 4:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to the '/profiler/*' endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab 
>   3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
>   3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 
> 
> Diff: https://reviews.apache.org/r/46497/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX. The endpoints were also tested by configuring with `../configure --enable-perftools`, and then hitting `/profiler/start` and `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER` environment variable set to 1.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/#review130429
-----------------------------------------------------------


Ship it!




Ship It!

- Kapil Arya


On April 25, 2016, 10:02 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46497/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 10:02 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to the '/profiler/*' endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab 
>   3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
>   3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 
> 
> Diff: https://reviews.apache.org/r/46497/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX. The endpoints were also tested by configuring with `../configure --enable-perftools`, and then hitting `/profiler/start` and `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER` environment variable set to 1.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/#review130438
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46254, 46255, 46258, 46259, 46260, 46261, 46262, 46461, 46462, 46497]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 25, 2016, 2:02 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46497/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 2:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to the '/profiler/*' endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab 
>   3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
>   3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 
> 
> Diff: https://reviews.apache.org/r/46497/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX. The endpoints were also tested by configuring with `../configure --enable-perftools`, and then hitting `/profiler/start` and `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER` environment variable set to 1.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/
-----------------------------------------------------------

(Updated April 25, 2016, 2:02 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
-------

Addressed comments.


Bugs: MESOS-4902
    https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
-------

Added authentication to the '/profiler/*' endpoints.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab 
  3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
  3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 

Diff: https://reviews.apache.org/r/46497/diff/


Testing (updated)
-------

`sudo make check` on OSX. The endpoints were also tested by configuring with `../configure --enable-perftools`, and then hitting `/profiler/start` and `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER` environment variable set to 1.


Thanks,

Greg Mann