[GitHub] rhtyd opened a new pull request #2407: CLOUDSTACK-10227: Add delay before reverting VM snapshot

[GitBox <gi...@apache.org>]

rhtyd opened a new pull request #2407: CLOUDSTACK-10227: Add delay before reverting VM snapshot
URL: https://github.com/apache/cloudstack/pull/2407
 
 
   As discovered and discussed in #2376, adding some delay after stopping
   the VM and reverting VM snapshot passes the
   `test_change_service_offering_for_vm_with_snapshots` test case. The
   suspect here is userVMDao or background vmsync that may not update
   the VM state to PowerOff.
   
   Pinging for review @mike-tutkowski @rafaelweingartner @DaanHoogland and others.
   Manually verified with QA:
   ```
   === TestName: test_change_service_offering_for_vm_with_snapshots | Status : SUCCESS ===
   ok
   
   Ran 1 test in 501.359s
   OK
   ```
   
   I think since this only changes the test file, it may be accepted only with at least code reviews. It's not a blocker, but fixing this smoketest will avoid getting incorrect failures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services