You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Simon Lessard (JIRA)" <ad...@incubator.apache.org> on 2006/07/19 17:53:16 UTC
[jira] Created: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Convert Trinidad to Java 5 standards and clean-up code
------------------------------------------------------
Key: ADFFACES-72
URL: http://issues.apache.org/jira/browse/ADFFACES-72
Project: MyFaces ADF-Faces
Issue Type: Improvement
Reporter: Simon Lessard
Priority: Minor
This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
- Remove references to deprecated API
- Remove unused imports
- Remove unread variables
- Change StringBuffer to StringBuilder where synchronization is not required
- Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
- Make all collection generic compliant
- Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
- Use enums
- Use concurrent API
- Add @Override annotation on overridden methods
- Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: (was: TAG_Java_5.patch)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: XMLMenuModel_5_standard.patch
Convert the new XMLMenuModel to 1.5 standard... Only 7,776 warnings to go :P
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, impl_5_standard_a_m.patch, XMLMenuModel_5_standard.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: IMPL_5_standard.zip
This patch takes care of the whole trinidad-impl project concerning JDK 5 standard. However, the tests were not converted yet and I'm quite sick of generics now.
I added a couple of TODO/FIXME to the code, mostly around Vector, Hashtable and Stack (those are quite evil classes) as well as some deprecated method calls and never read methods/members.
I transformed some loops to enhanced for structure, but only the most obvious ones because that task almost turned me insane with the generics alone. I had to modify API project a bit again because I found out that I inferred some types incorrectly, either too specific or too general.
I hope it please you,
Simon Lessard
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, IMPL_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12439003 ]
Simon Lessard commented on ADFFACES-72:
---------------------------------------
Hello garpnic,
This kind of discussion is held on the developer mailing, not on JIRA. To subscribe to the list you can send an empty mail to adffaces-dev-subscribe@incubator.apache.org. The main reason why it was converted is in prevision of JSF 1.2 which is based on Java 5. Furthermore, JSF 1.1 is not part of any JEE standard as it was created after JEE 1.4 and JEE 5 specification request JSF 1.2, not 1.1.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip, FINAL_Java_5_v2.zip, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: UNIT_TESTS_Java_5.zip
Convert unit tests for both API and IMPL project. I also had to modify around 6 clases from API and IMPL to either infer types differently or remove parametrization (Service provider namely which is sad because the parametrized version was nice).
Since there's no unit tests for unit tests, I tried to modify the classes the least possible, like I only applied enhanced for loop structure in two places where it was very obvious that the wanted behavior was to loop across all entries, all other loops remain unchanged.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UNIT_TESTS_Java_5.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: SubKeyMap_Java_5.patch
Convert SubKeyMap to Java 5 standard, without breaking unit tests.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12427588 ]
Simon Lessard commented on ADFFACES-72:
---------------------------------------
Note: If the final patch is applied, I think this issue can be closed as long as people submit Java 5 compliant patches for other issues. There's still some cleaning to do, but considering the amount of patches I already submitted for it, I think a new task issue to remove deprecated API calls and such would be better.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12425036 ]
Adam Winer commented on ADFFACES-72:
------------------------------------
Applied patch, mostly. There were a few locations where indexed-for-loops were undesirably converted to the JDK 1.5 form. Also, I did not apply the serialVersionUID additions (not a part of Java 5 standards), something that should be discussed before we add it.
@Simon: There were also some other changes made in this patch that should not have been, including ADFFACES-73 and changes to resource loading. It makes it much harder to review patches like this or track down any future bugs. It's a pain, but please stick to one patch for one issue.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: API_1_5_standard.zip
Same patch, but with ASF license
This patch convert the API project to JDK 5 standard. The other projects will come in a future patch. The patch also include the patch for converter message and EL of issue ADFFACES-73.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: Converters_5_standard.patch
Apply JDK 5 standard to impl/convert package after the client validation change.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, Converters_5_standard.patch, impl_5_standard_a_m.patch, XMLMenuModel_5_standard.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-72:
---------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: https://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating-core
> Reporter: Simon Lessard
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip, FINAL_Java_5_v2.zip, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "garpinc (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12438782 ]
garpinc commented on ADFFACES-72:
---------------------------------
Is Java 5 a necessary dependency? Tons of people are still forced to play in a jdk 1.4 environment. Why convert a codebase that works in jdk 1.4 to java 5 uness it is absolutely necessary?
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip, FINAL_Java_5_v2.zip, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Adam Winer updated ADFFACES-72:
-------------------------------
Status: Open (was: Patch Available)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: impl_5_standard_a_m.patch
JDK 5 standard for a part of the impl project. Corrected about 1,300 warnings Eclipse was giving. The patch converts all packages between trinidadinternal.agent and trinidadinternal.metadata.
I did my best to not corect any other bugs found to keep this patch as clean as possible. I did add some FIXME when I saw some strange pieces of code though.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, impl_5_standard_a_m.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: FINAL_Java_5.zip
Changed Collections.EMPTY_* to Collections.empty* since those are typesafe. This change allowed me to remove tome of the @SuppressWarnings("unchecked") that are not so desirable.
Also removed parametrization from RowKeySet to fix it to Set<Object>. This removed many warning as well some @SuppressWarnings and made the code cleaner imho.
Redid the parametrization of XMLMenuModel, making the XMLMenuModel patch I posted before for this issue obsolete.
Made inputNumberSpinbox Java 5 compliant.
Also fixed some more little details that showed up in the warning list now that my warning count is below 100 (47 actually).
The only remaining warnings are:
- Use of deprecated API
- Boolean assignment in an evaluation, used by assert enabledAssertion = true statements for instance.
- Missing @Override for some methods of autogenerated components. This issue is linked to the fact that maven-faces-plugin cannot detect methods it's overriding. Using a static list of method could works, but I would prefer to avoid that personally.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: (was: XMLMenuModel_5_standard.patch)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: Faces_plugin.patch
This patch allows faces plugin to generate Java 5 compliant code. The only missing feature is a way to recognize overriden getter and setter methods to add @Override to them.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: DEMO_SourceCodeServlet_Java_5.patch
Make SourceCodeServlet class of trinidad-demo Java 5 compliant (was not existing at the time I released the first patch or I overlooked it I guess).
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip, TAG_Java_5.patch, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: FINAL_Java_5_v2.zip
Oups, forgot 3 @Override in inputNumberSpinbox in the previous version
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip, FINAL_Java_5_v2.zip, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Status: Patch Available (was: Open)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12426095 ]
Adam Winer commented on ADFFACES-72:
------------------------------------
Comitted the IMPL patch, with some modifications; in particular, I had to revert the SubKeyMap change and fix the CapabilitiesDocumentParser change, as both broke the unit tests. (Please run unit tests before submitting a patch, esp. on of this size)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, DEMO_java_5.patch, IMPL_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: DEMO_java_5.patch
Convert demo project to jdk 5 standard, including the tests.
Regards
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, DEMO_java_5.patch, IMPL_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: API_template.patch
Update most of the templates to Java 5 standard. Most because RowKeySet is really hard to make Java 5 compliant in a clean way. Unit test were tested and worked well on my end.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12426382 ]
Adam Winer commented on ADFFACES-72:
------------------------------------
Committed all patches. Thanks for the huge effort!
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: XRTS_java_5.patch
This patch makes the code generated by xrts plugin Java 5 compliant. (The plugin itself is not made Java 5 compliant by this patch).
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: TAG_Java_5.patch
Wrong button :P
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip, TAG_Java_5.patch, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: DEMO_DateField_Java_5.patch
This patch convert 1 line I missed in DateFieldAsRenderer.java. It also remove usage of deprecated Date methods in favor of Calendar. Unit tests passed successfully,.No warning left in the demo projet.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip, TAG_Java_5.patch, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Status: Patch Available (was: Open)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: (was: API_1_5_standard.zip)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12425041 ]
Adam Winer commented on ADFFACES-72:
------------------------------------
Leaving open (and unassigned) 'til -impl package is also handled.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Status: Patch Available (was: Open)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UNIT_TESTS_Java_5.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: UNIT_UI_Java_5_v2.zip
This patch include SubKeyMap_Java_5, UNIT_TEST_Java_5 and UI_Java_5 patches in a single bundle because I was able to re-enable parametrization on service provider interface... Well... actually I should never have been unable to make the test case generic compliant... I actually forgot that casting was something allowed... ugh... yeah... ...
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: (was: impl_5_standard_a_m.patch)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: TAG_Java_5.patch
This patch modify maven-faces-plugin a bit more to generate valid Java 5 Tag class (the other patch was for UIComponents generation). This patch also get rid of all unused import within the Tag classes, fixing around 400 warnings alone.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12426819 ]
Adam Winer commented on ADFFACES-72:
------------------------------------
Checked in all of these patches to trunk; again, thanks!
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch, IMPL_5_standard.zip, TAG_Java_5.patch, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Adam Winer updated ADFFACES-72:
-------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Checked in the final patch.
I'll close this issue out. Thanks so much Simon for the enormous amount of work getting the code cleaned up like this!
As for moving forward - esp. figuring out how to keep the code clean - let's tackle that on the dev list.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip, FINAL_Java_5_v2.zip, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Adam Winer updated ADFFACES-72:
-------------------------------
Status: Open (was: Patch Available)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12426589 ]
Matthias Weßendorf commented on ADFFACES-72:
--------------------------------------------
I take a look at XRTS_java_5.patch and apply it to the branch (first)
thx.
btw. for the plugins we have separate "plugins" component in jira ;)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_java_5.patch, Faces_plugin.patch, IMPL_5_standard.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: I18N_Java_5.patch
This patch makes i18n plugin generate Java 5 compliant code. Well... actually in the case of that specific plugin, it's generate a single Java 5 compliant class, but oh well.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch, IMPL_5_standard.zip, TAG_Java_5.patch, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: UI_Java_5.zip
Convert ui and uinode packages to Java 5 standard. Considering those will be deleted over time but also considering we'll still have them for a while, I decided to convert those two package trees to reduce the amount of warnings shown in Eclipse (and other IDE?). However, the conversion is MINIMAL, most of the parametrization was done using <Object> so that almost no line of code was changed.
I now have 461 warnings left in my environment, not counting the XMLMenuModel patch that I uploaded a while back and was never applied (was buggy or something?). The menu model patch fix 100~150 warnings, leaving 300ish warnings. If I'm allowed to change RowKeySet signature as asked on the dev list, I would probably be able to fix another 200~250 warning, leaving only relevant warnings like deprecated API and such.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: API_1_5_standard.zip
This patch convert the API project to JDK 5 standard. The other projects will come in a future patch. The patch also include the patch for converter message and EL of issue ADFFACES-73.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards
and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: (was: Converters_5_standard.patch)
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5
standards and clean-up code
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12425830 ]
Simon Lessard commented on ADFFACES-72:
---------------------------------------
Only 4,976 warnings left on my end!
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, IMPL_5_standard.zip
>
>
> This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira