You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Otto Fowler <ot...@gmail.com> on 2018/01/12 13:05:26 UTC
[LANG] Github PR reviews
I see that github notices don’t get sent to this list, is there a procedure
to get a pr review?
Asking for a friend ;)
O
Re: [LANG] Github PR reviews
Posted by Gary Gregory <ga...@gmail.com>.
I am hoping to find time this weekend to review...
Gary
On Fri, Jan 12, 2018 at 9:40 AM, Otto Fowler <ot...@gmail.com>
wrote:
> https://github.com/apache/commons-lang/pull/311
>
> I did not see a mail for it. If someone else *did* see it, then I am
> sorry.
>
>
>
> On January 12, 2018 at 11:35:00, Gary Gregory (garydgregory@gmail.com)
> wrote:
>
> We should get emails from GitHub... What is the link to your PR?
>
> Gary
>
> On Fri, Jan 12, 2018 at 6:05 AM, Otto Fowler <ot...@gmail.com>
> wrote:
>
> > I see that github notices don’t get sent to this list, is there a
> procedure
> > to get a pr review?
> > Asking for a friend ;)
> >
> > O
> >
>
>
Re: Lists (was Re: [LANG] Github PR reviews)
Posted by sebb <se...@gmail.com>.
On 12 January 2018 at 18:58, Stefan Bodewig <bo...@apache.org> wrote:
> On 2018-01-12, sebb wrote:
>
>> On 12 January 2018 at 16:45, Stefan Bodewig <bo...@apache.org> wrote:
>
>>> By now we've got two different lists where notifications may end up,
>>> the github notifications for lang go to issues@commons, those for
>>> compress go to notifications@commons.
>
>> That seems wrong.
>
>> IMO
>> issues should be for JIRA
>> notifications for commits, CI
Did I really write that? Oops...
Of course (most) commits should go to commits@
However website build commits go to notifications, as they are not as
important (the source changes should go to commits@)
> Oh, we've also got commits@ which gets a bunch of svn commit messages as
> well as messages for some (all?) of the git repos. notifications seems
> to be svn for most components and CI.
>
> github integration looks very inconsistent. [lang] sends to issues,
> [compress] to notifications and [collections] and [imaging] even to dev
> - this is judging from the archive for the past few months.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Lists (was Re: [LANG] Github PR reviews)
Posted by Stefan Bodewig <bo...@apache.org>.
On 2018-01-12, sebb wrote:
> On 12 January 2018 at 16:45, Stefan Bodewig <bo...@apache.org> wrote:
>> By now we've got two different lists where notifications may end up,
>> the github notifications for lang go to issues@commons, those for
>> compress go to notifications@commons.
> That seems wrong.
> IMO
> issues should be for JIRA
> notifications for commits, CI
Oh, we've also got commits@ which gets a bunch of svn commit messages as
well as messages for some (all?) of the git repos. notifications seems
to be svn for most components and CI.
github integration looks very inconsistent. [lang] sends to issues,
[compress] to notifications and [collections] and [imaging] even to dev
- this is judging from the archive for the past few months.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [LANG] Github PR reviews
Posted by sebb <se...@gmail.com>.
On 12 January 2018 at 16:45, Stefan Bodewig <bo...@apache.org> wrote:
> On 2018-01-12, Otto Fowler wrote:
>
>> https://github.com/apache/commons-lang/pull/311
>
>> I did not see a mail for it. If someone else *did* see it, then I am sorry.
>
> https://lists.apache.org/thread.html/fb76f5e54f6f3713c06465539e13100f7e7dfc6b7874d1bea47c2ab4@%3Cissues.commons.apache.org%3E
>
> By now we've got two different lists where notifications may end up, the
> github notifications for lang go to issues@commons, those for compress
> go to notifications@commons.
That seems wrong.
IMO
issues should be for JIRA
notifications for commits, CI
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [LANG] Github PR reviews
Posted by Stefan Bodewig <bo...@apache.org>.
On 2018-01-12, Otto Fowler wrote:
> https://github.com/apache/commons-lang/pull/311
> I did not see a mail for it. If someone else *did* see it, then I am sorry.
https://lists.apache.org/thread.html/fb76f5e54f6f3713c06465539e13100f7e7dfc6b7874d1bea47c2ab4@%3Cissues.commons.apache.org%3E
By now we've got two different lists where notifications may end up, the
github notifications for lang go to issues@commons, those for compress
go to notifications@commons.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [LANG] Github PR reviews
Posted by Otto Fowler <ot...@gmail.com>.
https://github.com/apache/commons-lang/pull/311
I did not see a mail for it. If someone else *did* see it, then I am sorry.
On January 12, 2018 at 11:35:00, Gary Gregory (garydgregory@gmail.com)
wrote:
We should get emails from GitHub... What is the link to your PR?
Gary
On Fri, Jan 12, 2018 at 6:05 AM, Otto Fowler <ot...@gmail.com>
wrote:
> I see that github notices don’t get sent to this list, is there a
procedure
> to get a pr review?
> Asking for a friend ;)
>
> O
>
Re: [LANG] Github PR reviews
Posted by Gary Gregory <ga...@gmail.com>.
We should get emails from GitHub... What is the link to your PR?
Gary
On Fri, Jan 12, 2018 at 6:05 AM, Otto Fowler <ot...@gmail.com>
wrote:
> I see that github notices don’t get sent to this list, is there a procedure
> to get a pr review?
> Asking for a friend ;)
>
> O
>