You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sirona.apache.org by rm...@apache.org on 2014/03/23 18:58:37 UTC
svn commit: r1580554 - in /incubator/sirona/trunk/agent:
javaagent/src/test/java/org/apache/test/sirona/javaagent/SimpleTest.java
performance/aop/src/main/java/org/apache/sirona/aop/AbstractPerformanceInterceptor.java
Author: rmannibucau
Date: Sun Mar 23 17:58:37 2014
New Revision: 1580554
URL: http://svn.apache.org/r1580554
Log:
error keys shouldn't be the full stacktrace
Modified:
incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/test/sirona/javaagent/SimpleTest.java
incubator/sirona/trunk/agent/performance/aop/src/main/java/org/apache/sirona/aop/AbstractPerformanceInterceptor.java
Modified: incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/test/sirona/javaagent/SimpleTest.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/test/sirona/javaagent/SimpleTest.java?rev=1580554&r1=1580553&r2=1580554&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/test/sirona/javaagent/SimpleTest.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/test/sirona/javaagent/SimpleTest.java Sun Mar 23 17:58:37 2014
@@ -121,7 +121,7 @@ public class SimpleTest {
}
@Test
- @AgentArgs(value = CounterListener.DISABLE_PARAMETER_KEY)
+ @AgentArgs(CounterListener.DISABLE_PARAMETER_KEY)
public void primitiveDisable() {
assertHits("org.apache.test.sirona.javaagent.SimpleTest$ServiceTransform.soPrimitive", 0);
ServiceTransform.soPrimitive();
Modified: incubator/sirona/trunk/agent/performance/aop/src/main/java/org/apache/sirona/aop/AbstractPerformanceInterceptor.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/performance/aop/src/main/java/org/apache/sirona/aop/AbstractPerformanceInterceptor.java?rev=1580554&r1=1580553&r2=1580554&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/performance/aop/src/main/java/org/apache/sirona/aop/AbstractPerformanceInterceptor.java (original)
+++ incubator/sirona/trunk/agent/performance/aop/src/main/java/org/apache/sirona/aop/AbstractPerformanceInterceptor.java Sun Mar 23 17:58:37 2014
@@ -239,10 +239,13 @@ public abstract class AbstractPerformanc
final long elapsedTime = stopWatch.getElapsedTime();
if (error != null) {
+ /*
final ByteArrayOutputStream writer = new ByteArrayOutputStream();
error.printStackTrace(new PrintStream(writer));
final String toString = writer.toString();
- Repository.INSTANCE.getCounter(new Counter.Key(Role.FAILURES, toString.substring(0, Math.min(MAX_LENGTH, toString.length())))).add(elapsedTime);
+ */
+ Repository.INSTANCE.getCounter(
+ new Counter.Key(Role.FAILURES, error.getClass().getName() + ":" + (error.getMessage() != null ? error.getMessage() : ""))).add(elapsedTime);
}
activationContext.elapsedTime(elapsedTime);