You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ponymail.apache.org by se...@apache.org on 2017/01/09 10:18:52 UTC
incubator-ponymail git commit: inconsistent error reporting for
invalid mailing lists
Repository: incubator-ponymail
Updated Branches:
refs/heads/master aabee2908 -> 87769693a
inconsistent error reporting for invalid mailing lists
This fixes #112
Project: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/commit/87769693
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/tree/87769693
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/diff/87769693
Branch: refs/heads/master
Commit: 87769693a74be48b6f184ed2f1315bd908d56afc
Parents: aabee29
Author: Sebb <se...@apache.org>
Authored: Mon Jan 9 10:18:23 2017 +0000
Committer: Sebb <se...@apache.org>
Committed: Mon Jan 9 10:18:23 2017 +0000
----------------------------------------------------------------------
CHANGELOG.md | 1 +
site/js/dev/ponymail_pagebuilder.js | 5 ++++-
site/js/ponymail.js | 5 ++++-
3 files changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/87769693/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a4206b2..c5c3862 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -115,6 +115,7 @@
- stats.lua returns email time instead of os time in unixtime field (#331)
- stats.lua - cache causes inconsistent output when quick is used (#118)
- does not show mixed private/public lists unless logged in (#70)
+- inconsistent error reporting for invalid mailing lists (#112)
## CHANGES in 0.9b:
http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/87769693/site/js/dev/ponymail_pagebuilder.js
----------------------------------------------------------------------
diff --git a/site/js/dev/ponymail_pagebuilder.js b/site/js/dev/ponymail_pagebuilder.js
index 4c6530f..3a7e347 100644
--- a/site/js/dev/ponymail_pagebuilder.js
+++ b/site/js/dev/ponymail_pagebuilder.js
@@ -478,7 +478,7 @@ function getListInfo(list, xdomain, nopush) {
li.appendChild(a)
ll.appendChild(li)
if (typeof all_lists[xdomain][listname] == 'undefined') {
- if ((list && list.length > 1) && (!login || !login.credentials)) {
+ if (list && list.length > 1) {
popup("List not found!", "Looks like this list is either not here or private.<br>You can try <a href='" + URL_BASE + "/oauth.html'>Logging in</a> to resolve the situation.")
} else {
listname = key
@@ -517,6 +517,9 @@ function getListInfo(list, xdomain, nopush) {
}
}
+ } else {
+ // no such domain, report this as a missing list
+ popup("List not found!", "Looks like this list is either not here or private.<br>You can try <a href='" + URL_BASE + "/oauth.html'>Logging in</a> to resolve the situation.")
}
gxdomain = xdomain
addSearchBar();
http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/87769693/site/js/ponymail.js
----------------------------------------------------------------------
diff --git a/site/js/ponymail.js b/site/js/ponymail.js
index 06fa08c..b403424 100644
--- a/site/js/ponymail.js
+++ b/site/js/ponymail.js
@@ -4075,7 +4075,7 @@ function getListInfo(list, xdomain, nopush) {
li.appendChild(a)
ll.appendChild(li)
if (typeof all_lists[xdomain][listname] == 'undefined') {
- if ((list && list.length > 1) && (!login || !login.credentials)) {
+ if (list && list.length > 1) {
popup("List not found!", "Looks like this list is either not here or private.<br>You can try <a href='" + URL_BASE + "/oauth.html'>Logging in</a> to resolve the situation.")
} else {
listname = key
@@ -4114,6 +4114,9 @@ function getListInfo(list, xdomain, nopush) {
}
}
+ } else {
+ // no such domain, report this as a missing list
+ popup("List not found!", "Looks like this list is either not here or private.<br>You can try <a href='" + URL_BASE + "/oauth.html'>Logging in</a> to resolve the situation.")
}
gxdomain = xdomain
addSearchBar();