[jira] [Commented] (THRIFT-3959) Golang TSimpleServer Is More Of A TThreadedServer?

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927546#comment-15927546 ] 

ASF GitHub Bot commented on THRIFT-3959:
----------------------------------------

GitHub user JodeZer opened a pull request:

    https://github.com/apache/thrift/pull/1213

    THRIFT-3959 explain simpleServer is not a typical TSimpleServer

    l used to be confused by the name of TSimpleServer and at once thought golang is unable to use thrift cause there is no other server implementations.
    However,l changed my mind after checking the code of TSimpleServer .And Then, a simple multi-client demo proved my gusses.
    Thus , l try to explain this thing in annotation and hope others gophers not be confused again :)
    
    Happened to find the same topic on issue Thrift-3959 ,hope this works.
    https://issues.apache.org/jira/browse/THRIFT-3959

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JodeZer/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1213
    
----
commit d5f503344e845ee9cb235891796128e8a2dc5a49
Author: JodeZer <je...@hotmail.com>
Date:   2017-03-16T03:52:18Z

    THRIFT-3959 explain simpleServer is not a typical TSimpleServer

----


> Golang TSimpleServer Is More Of A TThreadedServer?
> --------------------------------------------------
>
>                 Key: THRIFT-3959
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3959
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>            Reporter: Paul Brown
>
> The documentation says TSimpleServer is a "Simple singlethreaded server for testing.", however the golang implementation looks it spawns a go routine to process each request: https://github.com/apache/thrift/blob/master/lib/go/thrift/simple_server.go#L134-L138
> Shouldn't it be renamed to TThreadedServer?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)