[GitHub] [flink] AHeise commented on a change in pull request #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator

[GitBox <gi...@apache.org>]

AHeise commented on a change in pull request #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319845990
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java
 ##########
 @@ -249,89 +239,53 @@ int getNumTasksScheduled() {
 	// ------------------------------------------------------------------------
 
 	/**
-	 * Internal task that is invoked by the timer service and triggers the target.
+	 * A context to which {@link ProcessingTimeCallback} would be passed to be invoked when a timer is up.
 	 */
-	private static final class TriggerTask implements Runnable {
+	public interface ScheduledCallbackExecutionContext {
 
 Review comment:
   Yes, fine by me. Can you also double-check if packet-private may also work (hard to tell in PR)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services