[jira] [Work logged] (COMPRESS-582) Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COMPRESS-582?focusedWorklogId=636437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636437 ]

ASF GitHub Bot logged work on COMPRESS-582:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/21 12:48
            Start Date: 10/Aug/21 12:48
    Worklog Time Spent: 10m 
      Work Description: blecher-at opened a new pull request #216:
URL: https://github.com/apache/commons-compress/pull/216


   fix for https://issues.apache.org/jira/projects/COMPRESS/issues/COMPRESS-582
   
   Upgrades the newly included harmony pack200 classes to support ASM >= 7.0
   Earlier Versions (4-6) fail the unittests.
   
   To test with most recent asm version, run ./mvnw test -Dasm.version=9.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 636437)
    Remaining Estimate: 0h
            Time Spent: 10m

> Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used
> --------------------------------------------------------------------------
>
>                 Key: COMPRESS-582
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-582
>             Project: Commons Compress
>          Issue Type: Bug
>    Affects Versions: 1.21
>            Reporter: Alex Landau
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I just tried to upgrade an existing codebase to commons-compress 1.21 (from 1.20, which was working correctly) and encountered the following error in code trying to use the Pack200CompressorOutputStream:
> {code:java}
> java.lang.IncompatibleClassChangeError: class 
> org.apache.commons.compress.harmony.pack200.Segment can not implement 
> org.objectweb.asm.ClassVisitor, because it is not an interface 
> (org.objectweb.asm.ClassVisitor is in unnamed module of loader 'app')
> {code}
> The Segment class {{implements}} rather than {{extends}} ClassVisitor. It looks like commons-compress is built against asm 3.2. Per [https://asm.ow2.io/versions.html], ClassVisitor was converted from an interface to an abstract class in asm 4.0, which was released in 2011, "in order to ensure backward binary compatibility in future ASM versions". To be clear, our project needs a more recent asm version on the classpath to support other libraries.
> I have a repro of the error here, in case it helps: [https://github.com/AlexLandau/commons-compress-asm-error]
> I want to add that I appreciate the effort you are making to support pack200 in a way that will outlast the JDK's native support.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)