[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2282: IGNITE-17298 Sql. Support BOOLEAN type.

["korlov42 (via GitHub)" <gi...@apache.org>]

korlov42 commented on code in PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1255678596


##########
modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleReader.java:
##########
@@ -79,6 +80,34 @@ public boolean hasNullValue(int index) {
         return begin == end;
     }
 
+    /**
+     * Reads value of specified element.
+     *
+     * @param index Element index.
+     * @return Element value.
+     */
+    public boolean booleanValue(int index) {
+        seek(index);
+
+        return ByteUtils.byteToBoolean(byteValue(begin, end));

Review Comment:
   I believe boolean deserves it's own methods in both parser and builder



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org