You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/06/06 06:01:22 UTC

Review Request 35170: Missing entries in oozie-site.xml after Falcon rolling upgrade

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35170/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-11749
    https://issues.apache.org/jira/browse/AMBARI-11749


Repository: ambari


Description
-------

After rolling upgrade from 2.2.7 -> 2.3.0 using Ambari (#VERSION_NUMBER=2.1.0-1900)

oozie-site.xml does not have bunch of properties (example below)
 <name>oozie.service.ActionService.executor.ext.classes</name>
 <name>oozie.service.ELService.ext.functions.coord-action-create</name>
 <name>oozie.service.ELService.ext.functions.coord-action-create-inst</name>
 <name>oozie.service.ELService.ext.functions.coord-action-start</name>
 

The problem here is that by the time that Falcon runs, Oozie has already changed the merged 2.3 desired configuration. There were a lot of ways I thought to get around this:

- Add a flag to the transfer to say whether to copy from current or desired
- Add a conditional around a transfer
- Just don't delete the properties


At the end of the day, it seems pretty straighforward to just not delete there properties in the Oozie update. If they exist, they are there for Falcon and they should be preserved.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0cee7b1 

Diff: https://reviews.apache.org/r/35170/diff/


Testing
-------

Upgraded Oozie and Falcon; verified the properties existed and SC's passed.


Thanks,

Jonathan Hurley


Re: Review Request 35170: Missing entries in oozie-site.xml after Falcon rolling upgrade

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35170/#review86946
-----------------------------------------------------------

Ship it!


Config action is hot!

- Nate Cole


On June 6, 2015, 12:01 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35170/
> -----------------------------------------------------------
> 
> (Updated June 6, 2015, 12:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11749
>     https://issues.apache.org/jira/browse/AMBARI-11749
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After rolling upgrade from 2.2.7 -> 2.3.0 using Ambari (#VERSION_NUMBER=2.1.0-1900)
> 
> oozie-site.xml does not have bunch of properties (example below)
>  <name>oozie.service.ActionService.executor.ext.classes</name>
>  <name>oozie.service.ELService.ext.functions.coord-action-create</name>
>  <name>oozie.service.ELService.ext.functions.coord-action-create-inst</name>
>  <name>oozie.service.ELService.ext.functions.coord-action-start</name>
>  
> 
> The problem here is that by the time that Falcon runs, Oozie has already changed the merged 2.3 desired configuration. There were a lot of ways I thought to get around this:
> 
> - Add a flag to the transfer to say whether to copy from current or desired
> - Add a conditional around a transfer
> - Just don't delete the properties
> 
> 
> At the end of the day, it seems pretty straighforward to just not delete there properties in the Oozie update. If they exist, they are there for Falcon and they should be preserved.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0cee7b1 
> 
> Diff: https://reviews.apache.org/r/35170/diff/
> 
> 
> Testing
> -------
> 
> Upgraded Oozie and Falcon; verified the properties existed and SC's passed.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>