You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/03 23:05:51 UTC
[GitHub] [airflow] HaloKo4 opened a new issue #14054: SambaHook using old unmaintained library
HaloKo4 opened a new issue #14054:
URL: https://github.com/apache/airflow/issues/14054
**Description**
The [SambaHook](https://github.com/apache/airflow/blob/master/airflow/providers/samba/hooks/samba.py#L26) currently using [pysmbclient](https://github.com/apache/airflow/blob/master/setup.py#L408) this library hasn't been updated since 2017 https://pypi.org/project/PySmbClient/
I think worth moving to https://pypi.org/project/smbprotocol/ which newer and maintained.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-853596094
It seems like [pysmb](https://github.com/miketeo/pysmb) is another choice. Not sure whether it or smbprotocol is better/more suitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
malthe commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-882280492
@uranusjr one deficiency in `pysmb` that I came upon was lack of Samba 2.1+ support, see https://github.com/miketeo/pysmb/issues/95#issuecomment-360295622.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #14054:
URL: https://github.com/apache/airflow/issues/14054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-853596094
It seems like [pysmb](https://github.com/miketeo/pysmb) is another choice. Not sure whether it or smbprotocol is better/more suitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Rishabhraghwendra18 commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
Rishabhraghwendra18 commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-787378848
I am really sorry guys. I am not able to setup the development on my machine . And I am also having university exams within this month .So I am not able to contribute 😞. I am unassingning myself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-773416166
Sure! I assigned you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Rishabhraghwendra18 commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
Rishabhraghwendra18 commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-773445797
@potiuk thanks man ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Rishabhraghwendra18 commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
Rishabhraghwendra18 commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-773410105
Hi...May I work on this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-789279410
@marcosmarxm Sure, all yours!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-787427921
> I am really sorry guys. I am not able to setup the development on my machine . And I am also having university exams within this month .So I am not able to contribute . I am unassingning myself.
Too bad. Next time maybe,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] HaloKo4 commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
HaloKo4 commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-779016530
thanks @Rishabhraghwendra18 looking forward to this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe edited a comment on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
malthe edited a comment on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-882280492
@uranusjr one deficiency in `pysmb` that I came upon was lack of Samba 2.1+ support, see https://github.com/miketeo/pysmb/issues/95#issuecomment-360295622.
I might be able to find time to dig into this – adding "credits support". If there's a reference implementation in Go, then it shouldn't be too hard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] marcosmarxm commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
marcosmarxm commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-789250751
@potiuk can I take this one instead? I'm finishing the Airbyte provider so right now is easier to do this modification :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Rishabhraghwendra18 commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
Rishabhraghwendra18 commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-787647380
ya..sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Rishabhraghwendra18 commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
Rishabhraghwendra18 commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-773410105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #14054: SambaHook using old unmaintained library
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #14054:
URL: https://github.com/apache/airflow/issues/14054#issuecomment-773416166
Sure! I assigned you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org