You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrey Dyatlov <ad...@mesosphere.io> on 2015/11/09 17:34:27 UTC
Review Request 40087: Added a list of protocols supported by the Mesos
fetcher as requested in MESOS-2783
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas and Bernd Mathiske.
Bugs: MESOS-2783
https://issues.apache.org/jira/browse/MESOS-2783
Repository: mesos
Description
-------
Documentation. Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783
Diffs
-----
docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733
Diff: https://reviews.apache.org/r/40087/diff/
Testing
-------
Problem: In the description of the MESOS-2783 the list of protocols or schemas supported by the Mesos fetcher is requested. The bug is marked as resolved, but the documentation still doesn't contain this list.
Solution: The list was made according to the following source files: src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
Thanks,
Andrey Dyatlov
Re: Review Request 40087: Added a list of protocols supported by the
Mesos fetcher as requested in MESOS-2783
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/#review105818
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Nov. 10, 2015, 2 a.m., Andrey Dyatlov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40087/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 2 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Bernd Mathiske.
>
>
> Bugs: MESOS-2783
> https://issues.apache.org/jira/browse/MESOS-2783
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documentation. Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783
>
>
> Diffs
> -----
>
> docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733
>
> Diff: https://reviews.apache.org/r/40087/diff/
>
>
> Testing
> -------
>
> Problem: In the description of the MESOS-2783 the list of protocols or schemas supported by the Mesos fetcher is requested. The bug is marked as resolved, but the documentation still doesn't contain this list.
> Solution: The list was made according to the following source files: src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
>
>
> Thanks,
>
> Andrey Dyatlov
>
>
Re: Review Request 40087: Added a list of protocols supported by the
Mesos fetcher as requested in MESOS-2783
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/#review105819
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Nov. 10, 2015, 11 a.m., Andrey Dyatlov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40087/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 11 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Bernd Mathiske.
>
>
> Bugs: MESOS-2783
> https://issues.apache.org/jira/browse/MESOS-2783
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documentation. Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783
>
>
> Diffs
> -----
>
> docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733
>
> Diff: https://reviews.apache.org/r/40087/diff/
>
>
> Testing
> -------
>
> Problem: In the description of the MESOS-2783 the list of protocols or schemas supported by the Mesos fetcher is requested. The bug is marked as resolved, but the documentation still doesn't contain this list.
> Solution: The list was made according to the following source files: src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
>
>
> Thanks,
>
> Andrey Dyatlov
>
>
Re: Review Request 40087: Added a list of protocols supported by the
Mesos fetcher as requested in MESOS-2783
Posted by Andrey Dyatlov <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 11 a.m.)
Review request for mesos, Alexander Rojas and Bernd Mathiske.
Bugs: MESOS-2783
https://issues.apache.org/jira/browse/MESOS-2783
Repository: mesos
Description
-------
Documentation. Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783
Diffs (updated)
-----
docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733
Diff: https://reviews.apache.org/r/40087/diff/
Testing
-------
Problem: In the description of the MESOS-2783 the list of protocols or schemas supported by the Mesos fetcher is requested. The bug is marked as resolved, but the documentation still doesn't contain this list.
Solution: The list was made according to the following source files: src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
Thanks,
Andrey Dyatlov
Re: Review Request 40087: Added a list of protocols supported by the
Mesos fetcher as requested in MESOS-2783
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/#review105693
-----------------------------------------------------------
docs/fetcher.md (line 19)
<https://reviews.apache.org/r/40087/#comment164295>
s/, it/and it
docs/fetcher.md (line 20)
<https://reviews.apache.org/r/40087/#comment164294>
s/supports/supports the
docs/fetcher.md (line 21)
<https://reviews.apache.org/r/40087/#comment164293>
s/local a/a local
docs/fetcher.md (line 22)
<https://reviews.apache.org/r/40087/#comment164297>
s/./, e.g., HDFS, S3. See the slave [confifuration documentation](/documentation/latest/configuration/) for how to configure the slave with a path to the Hadoop client.
- Bernd Mathiske
On Nov. 9, 2015, 8:34 a.m., Andrey Dyatlov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40087/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 8:34 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Bernd Mathiske.
>
>
> Bugs: MESOS-2783
> https://issues.apache.org/jira/browse/MESOS-2783
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documentation. Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783
>
>
> Diffs
> -----
>
> docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733
>
> Diff: https://reviews.apache.org/r/40087/diff/
>
>
> Testing
> -------
>
> Problem: In the description of the MESOS-2783 the list of protocols or schemas supported by the Mesos fetcher is requested. The bug is marked as resolved, but the documentation still doesn't contain this list.
> Solution: The list was made according to the following source files: src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
>
>
> Thanks,
>
> Andrey Dyatlov
>
>
Re: Review Request 40087: Added a list of protocols supported by the
Mesos fetcher as requested in MESOS-2783
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/#review105692
-----------------------------------------------------------
Bad patch!
Reviews applied: [40087]
Failed command: ./support/apply-review.sh -n -r 40087
Error:
2015-11-09 16:39:19 URL:https://reviews.apache.org/r/40087/diff/raw/ [981/981] -> "40087.patch" [1]
40087.patch:10: trailing whitespace.
supports HTTP, HTTPS, FTP and FTPS protocols. If the requested URI is based on
40087.patch:11: trailing whitespace.
some other protocol, then the fetcher tries to utilise local a Hadoop client
warning: 2 lines add whitespace errors.
Successfully applied: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783
Documentation. Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783
Review: https://reviews.apache.org/r/40087
docs/fetcher.md:20: trailing whitespace.
+supports HTTP, HTTPS, FTP and FTPS protocols. If the requested URI is based on
docs/fetcher.md:21: trailing whitespace.
+some other protocol, then the fetcher tries to utilise local a Hadoop client
Failed to commit patch
- Mesos ReviewBot
On Nov. 9, 2015, 4:34 p.m., Andrey Dyatlov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40087/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 4:34 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Bernd Mathiske.
>
>
> Bugs: MESOS-2783
> https://issues.apache.org/jira/browse/MESOS-2783
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documentation. Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783
>
>
> Diffs
> -----
>
> docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733
>
> Diff: https://reviews.apache.org/r/40087/diff/
>
>
> Testing
> -------
>
> Problem: In the description of the MESOS-2783 the list of protocols or schemas supported by the Mesos fetcher is requested. The bug is marked as resolved, but the documentation still doesn't contain this list.
> Solution: The list was made according to the following source files: src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
>
>
> Thanks,
>
> Andrey Dyatlov
>
>