You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Zsombor Gegesy <gz...@gmail.com> on 2017/02/12 15:13:19 UTC

Review Request 56580: [RANGER-1377] - code cleanup in security-admin module

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56580/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1377
    https://issues.apache.org/jira/browse/RANGER-1377


Repository: ranger


Description
-------

* use collection methods properly - addAll/removeAll/isEmpty
* string comparison methods


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java d4ab8d7df65a9ee5435f02acb5f3c4ec623967d4 
  security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java e90b1066fe38a43f1169271bc8e50991e29d1618 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8d8a9f8e2af92f982cc59c3237d9c50163 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a3b5a3bb1ce984647c87c45feeae05ae94 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f5120493fa10e999064b70b48e1363e4a738d55c 
  security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java ec744ea5590036bee8d3b7b38792eaecbd908cc1 
  security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 3542da2f2180eb797ca439fb55fa7c4240a9fd65 
  security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 7fa22929c8247846e002ee27b476b785a50bdad5 
  security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd8040ab0c5747e3d55032543a557384917bd 
  security-admin/src/main/java/org/apache/ranger/common/MapUtil.java 93fc76b455e7698baea9c7a7bdfa474457dba4f4 
  security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 830a04916f975c48393bcc75714f78348b5335ac 
  security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java 967804ada2b823efefec3f847df929f1deb4df81 
  security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4aaf678b8c329052d16e7a0b096b4f7115 
  security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 77119b16d2a9e4b4228fc3f2fb6d25851bfcf957 
  security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2c725a76141fdabfa61e2c3b0ed35652d3 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 6864c5a54a7e15c143e0c12aea282d733b8fb085 
  security-admin/src/main/java/org/apache/ranger/common/StringUtil.java b6192aece8a24a152be3d3c5b081e74a38a0e1be 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java e3b878b3ec0f75b0dc0975ee92bcb35158de5201 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java d718441ee9a4d74ed20477b39a9474dcdc828ebe 
  security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 9fa77f20acc622ed8f93f6c9d57a69eb67e4e406 
  security-admin/src/main/java/org/apache/ranger/entity/XXAccessAuditBase.java 8efcfc32dc02c801821706a266713d429a047776 
  security-admin/src/main/java/org/apache/ranger/entity/XXAsset.java 158c966aebf6a9a752721c66394c204a22e022b9 
  security-admin/src/main/java/org/apache/ranger/entity/XXAuditMap.java 95c2bf695db4482218caca4673974a2830e80f0e 
  security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java deedc87f79f0a56914d6dc13d559069de1ff0ec6 
  security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 04aedbd07c6a225b23faf50346fcaa932256c396 
  security-admin/src/main/java/org/apache/ranger/entity/XXPermMap.java 7c6b96c4261a5b77d10f5a6aeb0159c4b23b3e9f 
  security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java f7df09e98ec1e630c06c318778d45c4a52a8351e 
  security-admin/src/main/java/org/apache/ranger/entity/XXPortalUserRole.java 97f52c4ec0beab70cb6e29b87203e5eb590d58be 
  security-admin/src/main/java/org/apache/ranger/entity/XXResource.java e571a4f223c6503aa2441f027629db39dbf34fb7 
  security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a3c3918449f5f9207c91727d24b95da12b 
  security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java 16dca975307992c3de49b68e7702fab9369af649 
  security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 82ce8a09beb962c7c40dbe82934a8b4db60b2917 
  security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385ec24b82d749e516e3e274c4a3a48acfce 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 1c8828826b5a87c2e329e68b87393c46d77ece13 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 5c6ff58f063225d9635ed6d8a4f05962404f5be6 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908ba81b3469badf671b5af1268e9c21aa847 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 4b8b3ec28d3300b1372f41d47704e2d83e7d235a 
  security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java ceea47bbcf04fee9dae5f1f4847efc47cd0014f1 
  security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 512c567227746b840025eb3197f10d613c9a1c55 
  security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java d77e4f9bf327635ec5125e0feea991195c1d0ee1 
  security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java a48f4860056d68eff5374789d556854ee56a9eef 
  security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java 6f9350da2fee406f57428a6b00aab1c610fef59e 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367c36cdf85370ac7159bc427d188cf738e5 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java fb438a78e29dc98cbf5692543782c2911bf666a4 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7226b9f391c26bc1c615b9c214b758c6b1 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java daf3c8ef5711f90986573b97c00d0c4f33fadaa7 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java e84a1aaf69c2e1b80b0f2f15c7360da4bb8d6a44 
  security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c29c33088cd3d1a43394223d305a5780e64 
  security-admin/src/main/java/org/apache/ranger/security/listener/RangerHttpSessionListener.java e0069b6b79988a423e75c86ffb1bdb26b14d68ad 
  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 8d9363a81d5cab253c94a9020bb96950e63eb64f 
  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 948d328c68d8c93b995f3e8529896bf20a2c528a 
  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java e7e5f5dfccea3ebb54b8da64c90166e1462bba92 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java 36a0fa3f71a829ffee1ad4dd2051f2c34f149dcb 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa45f6f9b986511c314510e6f200247b869 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java d10fc46144c6747914b23fa563a04e03cd250a08 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb27a8aa8ea7ba6d7702c69459bc5eaf6e55 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 62e23c0213bdf0008c4178d24a1a2857de06d175 
  security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3bf2abc1f49d08f55f4c31a39aafd422512 
  security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 482f10cee4b2b825c876a03b0918a0913dfd3f19 
  security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776ac4d8367936ad46af465c28cdbd43c82ef 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java aacf398663d2d71be0236f83e8e293c9cf9fa72b 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b91109b49a5f373f4170c87a64df969698 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java 75237de147080faa97f438ca809eb0b2f1f06cb0 
  security-admin/src/main/java/org/apache/ranger/service/UserService.java 164e241952d30f8a3c39a2ad58790fbbea03eb9e 
  security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d3f894e30543473bd18c9689b8784276a0 
  security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f930bcc0fce3906ea17ae3d65bce555f4f 
  security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbcacd5b37dabbfa3e09d2a18ccd679ca021 
  security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735daace4c55c4bd93bbaf1847e51a34d74718 
  security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc9f0d64864e3bbd297ec351436a467604d 
  security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java f3f7c80008d7d5615b19bff9df7d7ae640107818 
  security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e5c85959ebda5aa7fa2e07184769ceef49 
  security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 817fddab265bb4d84432b14c3b561b8cd3f4d2ae 
  security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 1c43445a1f40762a00c77de420ad3307a0a5f7fa 
  security-admin/src/main/java/org/apache/ranger/service/XUserService.java 0f8156a8769f50abf3844222728a80790d175017 
  security-admin/src/main/java/org/apache/ranger/service/filter/RangerRESTAPIFilter.java 5b789251470fc2796c11d2fa24ba5831e71f6f73 
  security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760a9a9fea9ae8e1bae4a5164e9aed23394d 
  security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 3f7935ea116ed5b063ef55ea81668fca6225908e 
  security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java e0ab3729a46f278f7b5dae470e52ec7d88a68c16 
  security-admin/src/main/java/org/apache/ranger/util/RangerEnumUtil.java 6084972cbcedacdb176e8447b9f55b0697966e88 
  security-admin/src/main/java/org/apache/ranger/util/RangerRestUtil.java 9a2a50559189cf45e94211f5d41debff7d70aa8a 
  security-admin/src/main/java/org/apache/ranger/util/RestUtil.java b50d161a5978f4de2c6fcc3fb79ebface5da4ba1 
  security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d75f793c04d861b28db4d7bc9d3a784d1c 
  security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java bb1877543a415f6163905f9f9befb5d525fab38b 
  security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java dee31566c177e360d0fe05fdd0ac383cd5a73c97 
  security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773dac7c7b9c3076d604f61c12ca3fd008877f 

Diff: https://reviews.apache.org/r/56580/diff/


Testing
-------


Thanks,

Zsombor Gegesy


Re: Review Request 56580: [RANGER-1377] - code cleanup in security-admin module

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56580/#review165682
-----------------------------------------------------------



The changes are so large here I think we should wait until we get 0.7 out before applying this to master.

- Colm O hEigeartaigh


On Feb. 13, 2017, 3:44 p.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56580/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 3:44 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1377
>     https://issues.apache.org/jira/browse/RANGER-1377
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> * use collection methods properly - addAll/removeAll/isEmpty
> * string comparison methods
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java d4ab8d7 
>   security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java e90b106 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049 
>   security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java ec744ea 
>   security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 3542da2 
>   security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 7fa2292 
>   security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd80 
>   security-admin/src/main/java/org/apache/ranger/common/MapUtil.java 93fc76b 
>   security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 830a049 
>   security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java 967804a 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4 
>   security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 77119b1 
>   security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 6864c5a 
>   security-admin/src/main/java/org/apache/ranger/common/StringUtil.java b6192ae 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java e3b878b 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java d718441 
>   security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 9fa77f2 
>   security-admin/src/main/java/org/apache/ranger/entity/XXAccessAuditBase.java 8efcfc3 
>   security-admin/src/main/java/org/apache/ranger/entity/XXAsset.java 158c966 
>   security-admin/src/main/java/org/apache/ranger/entity/XXAuditMap.java 95c2bf6 
>   security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java deedc87 
>   security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 04aedbd 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPermMap.java 7c6b96c 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java f7df09e 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPortalUserRole.java 97f52c4 
>   security-admin/src/main/java/org/apache/ranger/entity/XXResource.java e571a4f 
>   security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a 
>   security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java 16dca97 
>   security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 82ce8a0 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 1c88288 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 5c6ff58 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908b 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 4b8b3ec 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java ceea47b 
>   security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 512c567 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java d77e4f9 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java a48f486 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java 6f9350d 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java fb438a7 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java daf3c8e 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java e84a1aa 
>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2 
>   security-admin/src/main/java/org/apache/ranger/security/listener/RangerHttpSessionListener.java e0069b6 
>   security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 8d9363a 
>   security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 948d328 
>   security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java e7e5f5d 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java 36a0fa3 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java d10fc46 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 62e23c0 
>   security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b 
>   security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 482f10c 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776a 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java aacf398 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java 75237de 
>   security-admin/src/main/java/org/apache/ranger/service/UserService.java 164e241 
>   security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d 
>   security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f 
>   security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc 
>   security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da 
>   security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc 
>   security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java f3f7c80 
>   security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e 
>   security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 817fdda 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 1c43445 
>   security-admin/src/main/java/org/apache/ranger/service/XUserService.java 0f8156a 
>   security-admin/src/main/java/org/apache/ranger/service/filter/RangerRESTAPIFilter.java 5b78925 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 3f7935e 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java e0ab372 
>   security-admin/src/main/java/org/apache/ranger/util/RangerEnumUtil.java 6084972 
>   security-admin/src/main/java/org/apache/ranger/util/RangerRestUtil.java 9a2a505 
>   security-admin/src/main/java/org/apache/ranger/util/RestUtil.java b50d161 
>   security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d 
>   security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java bb18775 
>   security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java dee3156 
>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da 
> 
> Diff: https://reviews.apache.org/r/56580/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>


Re: Review Request 56580: [RANGER-1377] - code cleanup in security-admin module

Posted by Zsombor Gegesy <gz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56580/
-----------------------------------------------------------

(Updated Feb. 13, 2017, 3:44 p.m.)


Review request for ranger.


Changes
-------

update to the latest


Bugs: RANGER-1377
    https://issues.apache.org/jira/browse/RANGER-1377


Repository: ranger


Description
-------

* use collection methods properly - addAll/removeAll/isEmpty
* string comparison methods


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java d4ab8d7 
  security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java e90b106 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049 
  security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java ec744ea 
  security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 3542da2 
  security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 7fa2292 
  security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd80 
  security-admin/src/main/java/org/apache/ranger/common/MapUtil.java 93fc76b 
  security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 830a049 
  security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java 967804a 
  security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4 
  security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 77119b1 
  security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 6864c5a 
  security-admin/src/main/java/org/apache/ranger/common/StringUtil.java b6192ae 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java e3b878b 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java d718441 
  security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 9fa77f2 
  security-admin/src/main/java/org/apache/ranger/entity/XXAccessAuditBase.java 8efcfc3 
  security-admin/src/main/java/org/apache/ranger/entity/XXAsset.java 158c966 
  security-admin/src/main/java/org/apache/ranger/entity/XXAuditMap.java 95c2bf6 
  security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java deedc87 
  security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 04aedbd 
  security-admin/src/main/java/org/apache/ranger/entity/XXPermMap.java 7c6b96c 
  security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java f7df09e 
  security-admin/src/main/java/org/apache/ranger/entity/XXPortalUserRole.java 97f52c4 
  security-admin/src/main/java/org/apache/ranger/entity/XXResource.java e571a4f 
  security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a 
  security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java 16dca97 
  security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 82ce8a0 
  security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 1c88288 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 5c6ff58 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908b 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 4b8b3ec 
  security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java ceea47b 
  security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 512c567 
  security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java d77e4f9 
  security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java a48f486 
  security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java 6f9350d 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java fb438a7 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java daf3c8e 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java e84a1aa 
  security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2 
  security-admin/src/main/java/org/apache/ranger/security/listener/RangerHttpSessionListener.java e0069b6 
  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 8d9363a 
  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 948d328 
  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java e7e5f5d 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java 36a0fa3 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java d10fc46 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 62e23c0 
  security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b 
  security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 482f10c 
  security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776a 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java aacf398 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java 75237de 
  security-admin/src/main/java/org/apache/ranger/service/UserService.java 164e241 
  security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d 
  security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f 
  security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc 
  security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da 
  security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc 
  security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java f3f7c80 
  security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e 
  security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 817fdda 
  security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 1c43445 
  security-admin/src/main/java/org/apache/ranger/service/XUserService.java 0f8156a 
  security-admin/src/main/java/org/apache/ranger/service/filter/RangerRESTAPIFilter.java 5b78925 
  security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760 
  security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 3f7935e 
  security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java e0ab372 
  security-admin/src/main/java/org/apache/ranger/util/RangerEnumUtil.java 6084972 
  security-admin/src/main/java/org/apache/ranger/util/RangerRestUtil.java 9a2a505 
  security-admin/src/main/java/org/apache/ranger/util/RestUtil.java b50d161 
  security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d 
  security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java bb18775 
  security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java dee3156 
  security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da 

Diff: https://reviews.apache.org/r/56580/diff/


Testing
-------


Thanks,

Zsombor Gegesy