You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/03/12 13:53:47 UTC

[GitHub] [incubator-skywalking] peng-yongsheng opened a new pull request #2352: Shutdown the OAP server when catch any exception.

peng-yongsheng opened a new pull request #2352: Shutdown the OAP server when catch any exception.
URL: https://github.com/apache/incubator-skywalking/pull/2352
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [X] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   OAP server will shutdown after catch those exceptions: ConfigFileNotFoundException, ModuleNotFoundException, ProviderNotFoundException, ServiceNotProvidedException, ModuleConfigException, ModuleStartException. But if the exception is not included in this collection.  The OAP server will still running. This is wrong because of this will cause subsequent modules not to start properly.  Clusters will take unpredictable problems.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services