You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/06/30 19:55:02 UTC

[GitHub] [incubator-datasketches-cpp] mdhimes commented on pull request #161: Fix vector_of_kll_sketches check for number of elements

mdhimes commented on pull request #161:
URL: https://github.com/apache/incubator-datasketches-cpp/pull/161#issuecomment-652009653


   Yeah, I see now that the unchecked approach is better.  I had misinterpreted part of the pybind docs, and I thought the result of the indexing issue (seeing what looked like unallocated memory) was due to the object not being densely packed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org