Re: [PR] feat: Include supervisorId in Kafka consumer metrics. (druid)

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on code in PR #19525:
URL: https://github.com/apache/druid/pull/19525#discussion_r3349175989


##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSamplerSpec.java:
##########
@@ -69,8 +69,12 @@ protected KafkaRecordSupplier createRecordSupplier()
       props.put("request.timeout.ms", Integer.toString(samplerConfig.getTimeoutMs()));
       KafkaSupervisorIOConfig kafkaSupervisorIOConfig = (KafkaSupervisorIOConfig) ioConfig;
 
-      return new KafkaRecordSupplier(props, objectMapper, kafkaSupervisorIOConfig.getConfigOverrides(),
-                                     kafkaSupervisorIOConfig.isMultiTopic()
+      return new KafkaRecordSupplier(
+          props,
+          objectMapper,
+          kafkaSupervisorIOConfig.getConfigOverrides(),
+          kafkaSupervisorIOConfig.isMultiTopic(),
+          null

Review Comment:
   Metrics wouldn't be emitted here, since nothing is going to install the `recordSupplier.monitor()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org