You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/12 01:19:42 UTC

[GitHub] [incubator-gobblin] ZihanLi58 opened a new pull request #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter

ZihanLi58 opened a new pull request #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2922

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1080

### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Add configuration to preserve schema creation time in converter, which can be used as schema version

### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Unit test

### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-gobblin] autumnust commented on issue #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter

Posted by GitBox <gi...@apache.org>.

autumnust commented on issue #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2922#issuecomment-598424984
 
 
   Can you rebase your changes against master ? Looks like it pulls in many other commits

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter

Posted by GitBox <gi...@apache.org>.

sv2000 commented on a change in pull request #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2922#discussion_r391819842
 
 

 ##########
 File path: gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
 ##########
 @@ -308,6 +308,8 @@
   /**
    * Converter configuration properties.
    */
+  public static final String CONVERTER_PRESERVE_SCHEMA_CREATION_TIME = "converter.preserve.schema.creation.time";
 
 Review comment:
   "converter.avro.include.schema.creation.time"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on issue #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter

Posted by GitBox <gi...@apache.org>.

sv2000 commented on issue #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2922#issuecomment-598357023
 
 
   @ZihanLi58 check on the travis failure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] ZihanLi58 closed pull request #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter

Posted by GitBox <gi...@apache.org>.

ZihanLi58 closed pull request #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2922
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter

Posted by GitBox <gi...@apache.org>.

sv2000 commented on a change in pull request #2922: [GOBBLIN-1080]Add configuration to preserve schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2922#discussion_r391820660
 
 

 ##########
 File path: gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java
 ##########
 @@ -116,6 +117,13 @@ public static boolean checkReaderWriterCompatibility(Schema readerSchema, Schema
     return SchemaCompatibility.checkReaderWriterCompatibility(readerSchema, writerSchema).getType().equals(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
   }
 
+  public static Schema preserveCreationTime(Schema inputSchema, Schema outputSchema) {
 
 Review comment:
   preserveCreationTime -> addSchemaCreationTime?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services