You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/11/07 01:55:20 UTC
[GitHub] [fineract] ptuomola opened a new pull request #1965: FINERACT-1435: Fix running the Spring Boot JAR after Jersey 2 upgrade
ptuomola opened a new pull request #1965:
URL: https://github.com/apache/fineract/pull/1965
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1965: FINERACT-1435: Fix running the Spring Boot JAR after Jersey 2 upgrade
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1965:
URL: https://github.com/apache/fineract/pull/1965#issuecomment-963145139
Hi - it works the same way as the Travis build: given the database is empty, the migration scripts are applied when the server comes up for the integration test
So far looks like the Travis and Github test are working the same way so as next step I think we can disable all the tests in Travis and just leave it to run SonarQube.
> On 8 Nov 2021, at 21:18, Awasum Yannick ***@***.***> wrote:
>
>
> Just an unrelated question about GitHub Action builds.. Does it actually show the logs when the DB is being migrated? I cannot find it.. At what stage is it migrating? When the stacks are coming up? Just trying to understand the new CI way of doing it.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <https://github.com/apache/fineract/pull/1965#issuecomment-963142237>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJVCVX26PSUFKE6TAGNZLUK7E3PANCNFSM5HQH2J7A>.
> Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1965: FINERACT-1435: Fix running the Spring Boot JAR after Jersey 2 upgrade
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1965:
URL: https://github.com/apache/fineract/pull/1965#issuecomment-963142237
Just an unrelated question about GitHub Action builds.. Does it actually show the logs when the DB is being migrated? I cannot find it.. At what stage is it migrating? When the stacks are coming up? Just trying to understand the new CI way of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #1965: FINERACT-1435: Fix running the Spring Boot JAR after Jersey 2 upgrade
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #1965:
URL: https://github.com/apache/fineract/pull/1965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1965: FINERACT-1435: Fix running the Spring Boot JAR after Jersey 2 upgrade
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1965:
URL: https://github.com/apache/fineract/pull/1965#issuecomment-967819734
Looks great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1965: FINERACT-1435: Fix running the Spring Boot JAR after Jersey 2 upgrade
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1965:
URL: https://github.com/apache/fineract/pull/1965#issuecomment-967790827
@vidakovic are you ok to merge this please? Otherwise the boot jar does not work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org