You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2007/04/18 01:13:15 UTC
[jira] Created: (HADOOP-1266) Remove DatanodeDescriptor dependency
from NetworkTopology
Remove DatanodeDescriptor dependency from NetworkTopology
---------------------------------------------------------
Key: HADOOP-1266
URL: https://issues.apache.org/jira/browse/HADOOP-1266
Project: Hadoop
Issue Type: Improvement
Components: dfs
Reporter: Konstantin Shvachko
Assigned To: Hairong Kuang
Fix For: 0.13.0
NetworkTopology should operate only with the Node interface.
The actual class DatanodeDescriptor, which implements Node should not be used inside.
We should avoid introducing unnecessary dependencies.
This is the typical case when everything can and should be defined using the interface.
This becomes a requirement if we want to measure distances between other than data-nodes
types of nodes like TaskTrackers, clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1266) Remove DatanodeDescriptor dependency
from NetworkTopology
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-1266:
----------------------------------
Attachment: GenericTopology.patch
This patch removes the NetworkTopology's dependency on DatanodeDescriptor.
> Remove DatanodeDescriptor dependency from NetworkTopology
> ---------------------------------------------------------
>
> Key: HADOOP-1266
> URL: https://issues.apache.org/jira/browse/HADOOP-1266
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Konstantin Shvachko
> Assignee: Hairong Kuang
> Attachments: GenericTopology.patch
>
>
> NetworkTopology should operate only with the Node interface.
> The actual class DatanodeDescriptor, which implements Node should not be used inside.
> We should avoid introducing unnecessary dependencies.
> This is the typical case when everything can and should be defined using the interface.
> This becomes a requirement if we want to measure distances between other than data-nodes
> types of nodes like TaskTrackers, clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1266) Remove DatanodeDescriptor
dependency from NetworkTopology
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525883 ]
Hadoop QA commented on HADOOP-1266:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12365303/GenericTopology.patch applied and successfully tested against trunk revision r573744.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/718/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/718/console
> Remove DatanodeDescriptor dependency from NetworkTopology
> ---------------------------------------------------------
>
> Key: HADOOP-1266
> URL: https://issues.apache.org/jira/browse/HADOOP-1266
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.14.1
> Reporter: Konstantin Shvachko
> Assignee: Hairong Kuang
> Fix For: 0.15.0
>
> Attachments: GenericTopology.patch
>
>
> NetworkTopology should operate only with the Node interface.
> The actual class DatanodeDescriptor, which implements Node should not be used inside.
> We should avoid introducing unnecessary dependencies.
> This is the typical case when everything can and should be defined using the interface.
> This becomes a requirement if we want to measure distances between other than data-nodes
> types of nodes like TaskTrackers, clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1266) Remove DatanodeDescriptor
dependency from NetworkTopology
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522225 ]
Arun C Murthy commented on HADOOP-1266:
---------------------------------------
+1, sounds like a good direction.
This is critical for getting map-reduce to be rack aware, specifically {{org.apache.hadoop.net.NetworkTopology.isOnSameRack}}. I need this for HADOOP-1721.
> Remove DatanodeDescriptor dependency from NetworkTopology
> ---------------------------------------------------------
>
> Key: HADOOP-1266
> URL: https://issues.apache.org/jira/browse/HADOOP-1266
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Konstantin Shvachko
> Assignee: Hairong Kuang
>
> NetworkTopology should operate only with the Node interface.
> The actual class DatanodeDescriptor, which implements Node should not be used inside.
> We should avoid introducing unnecessary dependencies.
> This is the typical case when everything can and should be defined using the interface.
> This becomes a requirement if we want to measure distances between other than data-nodes
> types of nodes like TaskTrackers, clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1266) Remove DatanodeDescriptor dependency
from NetworkTopology
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-1266:
----------------------------------
Fix Version/s: 0.15.0
Affects Version/s: 0.14.1
Status: Patch Available (was: Open)
> Remove DatanodeDescriptor dependency from NetworkTopology
> ---------------------------------------------------------
>
> Key: HADOOP-1266
> URL: https://issues.apache.org/jira/browse/HADOOP-1266
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.14.1
> Reporter: Konstantin Shvachko
> Assignee: Hairong Kuang
> Fix For: 0.15.0
>
> Attachments: GenericTopology.patch
>
>
> NetworkTopology should operate only with the Node interface.
> The actual class DatanodeDescriptor, which implements Node should not be used inside.
> We should avoid introducing unnecessary dependencies.
> This is the typical case when everything can and should be defined using the interface.
> This becomes a requirement if we want to measure distances between other than data-nodes
> types of nodes like TaskTrackers, clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1266) Remove DatanodeDescriptor dependency
from NetworkTopology
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1266:
-------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks Hairong!
> Remove DatanodeDescriptor dependency from NetworkTopology
> ---------------------------------------------------------
>
> Key: HADOOP-1266
> URL: https://issues.apache.org/jira/browse/HADOOP-1266
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.14.1
> Reporter: Konstantin Shvachko
> Assignee: Hairong Kuang
> Fix For: 0.15.0
>
> Attachments: GenericTopology.patch
>
>
> NetworkTopology should operate only with the Node interface.
> The actual class DatanodeDescriptor, which implements Node should not be used inside.
> We should avoid introducing unnecessary dependencies.
> This is the typical case when everything can and should be defined using the interface.
> This becomes a requirement if we want to measure distances between other than data-nodes
> types of nodes like TaskTrackers, clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1266) Remove DatanodeDescriptor
dependency from NetworkTopology
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525798 ]
dhruba borthakur commented on HADOOP-1266:
------------------------------------------
+1. Code looks good.
> Remove DatanodeDescriptor dependency from NetworkTopology
> ---------------------------------------------------------
>
> Key: HADOOP-1266
> URL: https://issues.apache.org/jira/browse/HADOOP-1266
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Konstantin Shvachko
> Assignee: Hairong Kuang
> Attachments: GenericTopology.patch
>
>
> NetworkTopology should operate only with the Node interface.
> The actual class DatanodeDescriptor, which implements Node should not be used inside.
> We should avoid introducing unnecessary dependencies.
> This is the typical case when everything can and should be defined using the interface.
> This becomes a requirement if we want to measure distances between other than data-nodes
> types of nodes like TaskTrackers, clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.