You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/30 10:59:14 UTC

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5905: arch/risc-v: Store/Restore FPU register in exception_common

pussuw commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-nuttx/pull/5905#discussion_r838408788



##########
File path: arch/risc-v/src/common/riscv_exception_common.S
##########
@@ -147,6 +155,10 @@ exception_common:
   REGLOAD    s0, REG_INT_CTX(sp) /* restore mstatus   */
   csrw       mstatus, s0
 
+#ifdef CONFIG_ARCH_FPU

Review comment:
       Ordering should be:
   1. riscv_restorefpu() <- this modifies the context, not the status register first
   2. restore mstatus <- restore status register with the updated context




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org