You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "Kami (via GitHub)" <gi...@apache.org> on 2023/01/28 19:35:59 UTC
[GitHub] [libcloud] Kami opened a new pull request, #1852: Clean up compute drive (based on top of #1743)
Kami opened a new pull request, #1852:
URL: https://github.com/apache/libcloud/pull/1852
This pull request is based on top of #1743. It synchronized that branch with latest trunk (there were a lot of conflicts due to the recent reformatting of the code in trunk).
I still need to go over the whole diff and changes again to ensure there are no bad conflict resolutions since there were many conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1852: Clean up compute drive (based on top of #1743)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1852:
URL: https://github.com/apache/libcloud/pull/1852#issuecomment-1407471836
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1852](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f43cad9) into [trunk](https://codecov.io/gh/apache/libcloud/commit/4e779e4c1a6b1149030722f9ee7b1ac26d4b249f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e779e4) will **decrease** coverage by `0.30%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f43cad9 differs from pull request most recent head 4063c31. Consider uploading reports for the commit 4063c31 to get more accurate results
[](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1852 +/- ##
==========================================
- Coverage 83.40% 83.10% -0.30%
==========================================
Files 403 353 -50
Lines 88251 81269 -6982
Branches 9347 8587 -760
==========================================
- Hits 73602 67541 -6061
+ Misses 11465 10922 -543
+ Partials 3184 2806 -378
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/common/dimensiondata.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2RpbWVuc2lvbmRhdGEucHk=) | `94.92% <ø> (ø)` | |
| [libcloud/common/nttcis.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL250dGNpcy5weQ==) | `73.58% <ø> (ø)` | |
| [libcloud/compute/base.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9iYXNlLnB5) | `92.85% <ø> (ø)` | |
| [libcloud/compute/drivers/\_\_init\_\_.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
| [libcloud/compute/drivers/opennebula.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5uZWJ1bGEucHk=) | `94.28% <ø> (ø)` | |
| [libcloud/compute/providers.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9wcm92aWRlcnMucHk=) | `87.50% <ø> (ø)` | |
| [libcloud/compute/types.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS90eXBlcy5weQ==) | `100.00% <ø> (ø)` | |
| [libcloud/container/providers.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL3Byb3ZpZGVycy5weQ==) | `66.66% <ø> (ø)` | |
| [libcloud/container/types.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL3R5cGVzLnB5) | `92.00% <ø> (-0.31%)` | :arrow_down: |
| [libcloud/dns/providers.py](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvZG5zL3Byb3ZpZGVycy5weQ==) | `57.14% <ø> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e779e4...4063c31](https://codecov.io/gh/apache/libcloud/pull/1852?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami merged pull request #1852: Clean up compute drive (based on top of #1743)
Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami merged PR #1852:
URL: https://github.com/apache/libcloud/pull/1852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org