You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/16 22:56:32 UTC

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15541: [Opperf] Add normal, uniform ops to random_sampling_operators

sandeep-krishnamurthy commented on a change in pull request #15541: [Opperf] Add normal, uniform ops to random_sampling_operators
URL: https://github.com/apache/incubator-mxnet/pull/15541#discussion_r304160063
 
 

 ##########
 File path: benchmark/opperf/utils/op_registry_utils.py
 ##########
 @@ -212,10 +212,13 @@ def get_all_random_sampling_operators():
     # Get all mxnet operators
     mx_operators = _get_all_mxnet_operators()
 
+    # Deprecated random sampling operators
 
 Review comment:
   Let us not add deprecated operators? 
   May be you can update _get_all_mxnet_operators to not return deprecated ops. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services