You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Vinay Varma <vi...@citrix.com> on 2014/05/09 14:57:48 UTC
Review Request 21263: CLOODSTACK-6282: Added tests to IP Addess and divided
test_escalations into individual files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21263/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
CLOODSTACK-6282: Added tests to IP Addess and divided test_escalations into individual files based on their functionality
Executed the tests in master and 4.4-forward branch and are running fine.
Attached are the results files for each of the .py file in master and in 4.4-forward branches
Diffs
-----
test/integration/component/test_escalations_instances.py PRE-CREATION
test/integration/component/test_escalations_ipaddresses.py PRE-CREATION
test/integration/component/test_escalations_isos.py PRE-CREATION
test/integration/component/test_escalations_securitygroups.py PRE-CREATION
test/integration/component/test_escalations_snapshots.py PRE-CREATION
test/integration/component/test_escalations_templates.py PRE-CREATION
test/integration/component/test_escalations_volumes.py PRE-CREATION
test/integration/component/test_escalations_vpncustomergateways.py PRE-CREATION
tools/marvin/marvin/lib/base.py 88e6d9a
Diff: https://reviews.apache.org/r/21263/diff/
Testing
-------
Executed the tests in master and 4.4-forward branch and are running fine.
Attached are the results files for each of the .py file in master and in 4.4-forward branches
File Attachments
----------------
MasterResults-Instances.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/406e33de-cc24-40e3-84c1-5a6d65a5d148__MasterResults-Instances.txt
MasterResults-IpAddresses.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/dab25ce0-3d8b-450e-a5d7-8319b3222080__MasterResults-IpAddresses.txt
MasterResults-Isos.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/55ef7b92-ba30-4297-9518-ea41dfa3b873__MasterResults-Isos.txt
MasterResults-SecurityGroups.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/db59e0ec-3980-4486-92aa-9f9ca07619dc__MasterResults-SecurityGroups.txt
MasterResults-Snapshots.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/0f1303df-00dd-4535-bbbb-f8fe24fb00ec__MasterResults-Snapshots.txt
MasterResults-Templates.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/27803766-d7d5-477a-9cb4-00af19707268__MasterResults-Templates.txt
MasterResults-VPNCustomerGateway.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/fb836ae9-030d-4e47-b482-8329fd891415__MasterResults-VPNCustomerGateway.txt
MasterResults-Volumes.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/948f0888-ceac-4202-a430-4e3fb426bc9d__MasterResults-Volumes.txt
4.4Results-Instances.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/31828ac7-98d9-4f18-a82b-4802e798573e__4.4Results-Instances.txt
4.4Results-IpAddresses.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/4f450475-1fbf-4883-8c7c-5594b01fcc94__4.4Results-IpAddresses.txt
4.4Results-Isos.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/31c9fc6e-2a82-4dc6-9e22-1ec8b4752695__4.4Results-Isos.txt
4.4Results-SecurityGroups.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/dcd978be-178b-4ef8-b98b-b685b688478f__4.4Results-SecurityGroups.txt
4.4Results-Snapshots.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/443d5c45-3037-45c5-a8ac-0e2cdc0ca12b__4.4Results-Snapshots.txt
4.4Results-Templates.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/7e95dffd-bbed-46c7-8d95-9ee60f377bb0__4.4Results-Templates.txt
4.4Results-Volumes.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/35ad618d-012b-4dfd-ad3e-9af887654579__4.4Results-Volumes.txt
4.4Results-VPNCustomerGateways.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/9fdb47c4-9bba-4ee6-943c-e07a7b5b55e2__4.4Results-VPNCustomerGateways.txt
Thanks,
Vinay Varma
Re: Review Request 21263: CLOODSTACK-6282: Added tests to IP Addess and
divided test_escalations into individual files
Posted by Vinay Varma <vi...@citrix.com>.
> On May 12, 2014, 10:53 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_escalations_instances.py, line 66
> > <https://reviews.apache.org/r/21263/diff/1/?file=577298#file577298line66>
> >
> > Retrieve the zone name using getZoneForTests() under get_zone. Look for other test suites for Example.
We are not retrieving the zone name using getZoneForTests() at class setup as we are having tests which are specific to Basic and tests which are specific to Advanced zones. If we specify the name of the Zone and retreive based on it then the tests which are specific to other zones in the same class would fail. If we donot specify zone name and get the underlying zone from its setup then these tests would not fail.
- Vinay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21263/#review42678
-----------------------------------------------------------
On May 9, 2014, 12:57 p.m., Vinay Varma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21263/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOODSTACK-6282: Added tests to IP Addess and divided test_escalations into individual files based on their functionality
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py PRE-CREATION
> test/integration/component/test_escalations_ipaddresses.py PRE-CREATION
> test/integration/component/test_escalations_isos.py PRE-CREATION
> test/integration/component/test_escalations_securitygroups.py PRE-CREATION
> test/integration/component/test_escalations_snapshots.py PRE-CREATION
> test/integration/component/test_escalations_templates.py PRE-CREATION
> test/integration/component/test_escalations_volumes.py PRE-CREATION
> test/integration/component/test_escalations_vpncustomergateways.py PRE-CREATION
> tools/marvin/marvin/lib/base.py 88e6d9a
>
> Diff: https://reviews.apache.org/r/21263/diff/
>
>
> Testing
> -------
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> File Attachments
> ----------------
>
> MasterResults-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/406e33de-cc24-40e3-84c1-5a6d65a5d148__MasterResults-Instances.txt
> MasterResults-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dab25ce0-3d8b-450e-a5d7-8319b3222080__MasterResults-IpAddresses.txt
> MasterResults-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/55ef7b92-ba30-4297-9518-ea41dfa3b873__MasterResults-Isos.txt
> MasterResults-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/db59e0ec-3980-4486-92aa-9f9ca07619dc__MasterResults-SecurityGroups.txt
> MasterResults-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/0f1303df-00dd-4535-bbbb-f8fe24fb00ec__MasterResults-Snapshots.txt
> MasterResults-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/27803766-d7d5-477a-9cb4-00af19707268__MasterResults-Templates.txt
> MasterResults-VPNCustomerGateway.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/fb836ae9-030d-4e47-b482-8329fd891415__MasterResults-VPNCustomerGateway.txt
> MasterResults-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/948f0888-ceac-4202-a430-4e3fb426bc9d__MasterResults-Volumes.txt
> 4.4Results-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31828ac7-98d9-4f18-a82b-4802e798573e__4.4Results-Instances.txt
> 4.4Results-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/4f450475-1fbf-4883-8c7c-5594b01fcc94__4.4Results-IpAddresses.txt
> 4.4Results-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31c9fc6e-2a82-4dc6-9e22-1ec8b4752695__4.4Results-Isos.txt
> 4.4Results-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dcd978be-178b-4ef8-b98b-b685b688478f__4.4Results-SecurityGroups.txt
> 4.4Results-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/443d5c45-3037-45c5-a8ac-0e2cdc0ca12b__4.4Results-Snapshots.txt
> 4.4Results-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/7e95dffd-bbed-46c7-8d95-9ee60f377bb0__4.4Results-Templates.txt
> 4.4Results-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/35ad618d-012b-4dfd-ad3e-9af887654579__4.4Results-Volumes.txt
> 4.4Results-VPNCustomerGateways.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/9fdb47c4-9bba-4ee6-943c-e07a7b5b55e2__4.4Results-VPNCustomerGateways.txt
>
>
> Thanks,
>
> Vinay Varma
>
>
Re: Review Request 21263: CLOODSTACK-6282: Added tests to IP Addess and
divided test_escalations into individual files
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On May 12, 2014, 10:53 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_escalations_instances.py, line 66
> > <https://reviews.apache.org/r/21263/diff/1/?file=577298#file577298line66>
> >
> > Retrieve the zone name using getZoneForTests() under get_zone. Look for other test suites for Example.
>
> Vinay Varma wrote:
> We are not retrieving the zone name using getZoneForTests() at class setup as we are having tests which are specific to Basic and tests which are specific to Advanced zones. If we specify the name of the Zone and retreive based on it then the tests which are specific to other zones in the same class would fail. If we donot specify zone name and get the underlying zone from its setup then these tests would not fail.
That should not be an issue. Please change it accordingly. If we have one zone, then getZoneForTests() will pick up that, its same as picking up underlying zone from setup. It will give a flexibility to pick up zone from command line switch. TestCases should not fail by adding this.
When running nose tests we don't run a test case pertaining to basic zone against advanced zone setup, for that we have to use tags. We added tags on top of each testcase for that. So, nosetests-2.7... -atags=basic will pick up only basic zone test cases.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21263/#review42678
-----------------------------------------------------------
On May 9, 2014, 12:57 p.m., Vinay Varma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21263/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOODSTACK-6282: Added tests to IP Addess and divided test_escalations into individual files based on their functionality
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py PRE-CREATION
> test/integration/component/test_escalations_ipaddresses.py PRE-CREATION
> test/integration/component/test_escalations_isos.py PRE-CREATION
> test/integration/component/test_escalations_securitygroups.py PRE-CREATION
> test/integration/component/test_escalations_snapshots.py PRE-CREATION
> test/integration/component/test_escalations_templates.py PRE-CREATION
> test/integration/component/test_escalations_volumes.py PRE-CREATION
> test/integration/component/test_escalations_vpncustomergateways.py PRE-CREATION
> tools/marvin/marvin/lib/base.py 88e6d9a
>
> Diff: https://reviews.apache.org/r/21263/diff/
>
>
> Testing
> -------
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> File Attachments
> ----------------
>
> MasterResults-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/406e33de-cc24-40e3-84c1-5a6d65a5d148__MasterResults-Instances.txt
> MasterResults-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dab25ce0-3d8b-450e-a5d7-8319b3222080__MasterResults-IpAddresses.txt
> MasterResults-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/55ef7b92-ba30-4297-9518-ea41dfa3b873__MasterResults-Isos.txt
> MasterResults-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/db59e0ec-3980-4486-92aa-9f9ca07619dc__MasterResults-SecurityGroups.txt
> MasterResults-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/0f1303df-00dd-4535-bbbb-f8fe24fb00ec__MasterResults-Snapshots.txt
> MasterResults-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/27803766-d7d5-477a-9cb4-00af19707268__MasterResults-Templates.txt
> MasterResults-VPNCustomerGateway.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/fb836ae9-030d-4e47-b482-8329fd891415__MasterResults-VPNCustomerGateway.txt
> MasterResults-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/948f0888-ceac-4202-a430-4e3fb426bc9d__MasterResults-Volumes.txt
> 4.4Results-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31828ac7-98d9-4f18-a82b-4802e798573e__4.4Results-Instances.txt
> 4.4Results-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/4f450475-1fbf-4883-8c7c-5594b01fcc94__4.4Results-IpAddresses.txt
> 4.4Results-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31c9fc6e-2a82-4dc6-9e22-1ec8b4752695__4.4Results-Isos.txt
> 4.4Results-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dcd978be-178b-4ef8-b98b-b685b688478f__4.4Results-SecurityGroups.txt
> 4.4Results-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/443d5c45-3037-45c5-a8ac-0e2cdc0ca12b__4.4Results-Snapshots.txt
> 4.4Results-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/7e95dffd-bbed-46c7-8d95-9ee60f377bb0__4.4Results-Templates.txt
> 4.4Results-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/35ad618d-012b-4dfd-ad3e-9af887654579__4.4Results-Volumes.txt
> 4.4Results-VPNCustomerGateways.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/9fdb47c4-9bba-4ee6-943c-e07a7b5b55e2__4.4Results-VPNCustomerGateways.txt
>
>
> Thanks,
>
> Vinay Varma
>
>
Re: Review Request 21263: CLOODSTACK-6282: Added tests to IP Addess and
divided test_escalations into individual files
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21263/#review42678
-----------------------------------------------------------
test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/21263/#comment76492>
Retrieve the zone name using getZoneForTests() under get_zone. Look for other test suites for Example.
- Santhosh Edukulla
On May 9, 2014, 12:57 p.m., Vinay Varma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21263/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOODSTACK-6282: Added tests to IP Addess and divided test_escalations into individual files based on their functionality
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py PRE-CREATION
> test/integration/component/test_escalations_ipaddresses.py PRE-CREATION
> test/integration/component/test_escalations_isos.py PRE-CREATION
> test/integration/component/test_escalations_securitygroups.py PRE-CREATION
> test/integration/component/test_escalations_snapshots.py PRE-CREATION
> test/integration/component/test_escalations_templates.py PRE-CREATION
> test/integration/component/test_escalations_volumes.py PRE-CREATION
> test/integration/component/test_escalations_vpncustomergateways.py PRE-CREATION
> tools/marvin/marvin/lib/base.py 88e6d9a
>
> Diff: https://reviews.apache.org/r/21263/diff/
>
>
> Testing
> -------
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> File Attachments
> ----------------
>
> MasterResults-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/406e33de-cc24-40e3-84c1-5a6d65a5d148__MasterResults-Instances.txt
> MasterResults-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dab25ce0-3d8b-450e-a5d7-8319b3222080__MasterResults-IpAddresses.txt
> MasterResults-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/55ef7b92-ba30-4297-9518-ea41dfa3b873__MasterResults-Isos.txt
> MasterResults-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/db59e0ec-3980-4486-92aa-9f9ca07619dc__MasterResults-SecurityGroups.txt
> MasterResults-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/0f1303df-00dd-4535-bbbb-f8fe24fb00ec__MasterResults-Snapshots.txt
> MasterResults-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/27803766-d7d5-477a-9cb4-00af19707268__MasterResults-Templates.txt
> MasterResults-VPNCustomerGateway.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/fb836ae9-030d-4e47-b482-8329fd891415__MasterResults-VPNCustomerGateway.txt
> MasterResults-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/948f0888-ceac-4202-a430-4e3fb426bc9d__MasterResults-Volumes.txt
> 4.4Results-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31828ac7-98d9-4f18-a82b-4802e798573e__4.4Results-Instances.txt
> 4.4Results-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/4f450475-1fbf-4883-8c7c-5594b01fcc94__4.4Results-IpAddresses.txt
> 4.4Results-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31c9fc6e-2a82-4dc6-9e22-1ec8b4752695__4.4Results-Isos.txt
> 4.4Results-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dcd978be-178b-4ef8-b98b-b685b688478f__4.4Results-SecurityGroups.txt
> 4.4Results-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/443d5c45-3037-45c5-a8ac-0e2cdc0ca12b__4.4Results-Snapshots.txt
> 4.4Results-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/7e95dffd-bbed-46c7-8d95-9ee60f377bb0__4.4Results-Templates.txt
> 4.4Results-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/35ad618d-012b-4dfd-ad3e-9af887654579__4.4Results-Volumes.txt
> 4.4Results-VPNCustomerGateways.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/9fdb47c4-9bba-4ee6-943c-e07a7b5b55e2__4.4Results-VPNCustomerGateways.txt
>
>
> Thanks,
>
> Vinay Varma
>
>
Re: Review Request 21263: CLOODSTACK-6282: Added tests to IP Addess and
divided test_escalations into individual files
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21263/#review43347
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On May 19, 2014, 11:21 a.m., Vinay Varma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21263/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:21 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOODSTACK-6282: Added tests to IP Addess and divided test_escalations into individual files based on their functionality
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py PRE-CREATION
> test/integration/component/test_escalations_ipaddresses.py PRE-CREATION
> test/integration/component/test_escalations_isos.py PRE-CREATION
> test/integration/component/test_escalations_securitygroups.py PRE-CREATION
> test/integration/component/test_escalations_snapshots.py PRE-CREATION
> test/integration/component/test_escalations_templates.py PRE-CREATION
> test/integration/component/test_escalations_volumes.py PRE-CREATION
> test/integration/component/test_escalations_vpncustomergateways.py PRE-CREATION
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21263/diff/
>
>
> Testing
> -------
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> File Attachments
> ----------------
>
> MasterResults-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/406e33de-cc24-40e3-84c1-5a6d65a5d148__MasterResults-Instances.txt
> MasterResults-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dab25ce0-3d8b-450e-a5d7-8319b3222080__MasterResults-IpAddresses.txt
> MasterResults-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/55ef7b92-ba30-4297-9518-ea41dfa3b873__MasterResults-Isos.txt
> MasterResults-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/db59e0ec-3980-4486-92aa-9f9ca07619dc__MasterResults-SecurityGroups.txt
> MasterResults-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/0f1303df-00dd-4535-bbbb-f8fe24fb00ec__MasterResults-Snapshots.txt
> MasterResults-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/27803766-d7d5-477a-9cb4-00af19707268__MasterResults-Templates.txt
> MasterResults-VPNCustomerGateway.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/fb836ae9-030d-4e47-b482-8329fd891415__MasterResults-VPNCustomerGateway.txt
> MasterResults-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/948f0888-ceac-4202-a430-4e3fb426bc9d__MasterResults-Volumes.txt
> 4.4Results-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31828ac7-98d9-4f18-a82b-4802e798573e__4.4Results-Instances.txt
> 4.4Results-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/4f450475-1fbf-4883-8c7c-5594b01fcc94__4.4Results-IpAddresses.txt
> 4.4Results-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31c9fc6e-2a82-4dc6-9e22-1ec8b4752695__4.4Results-Isos.txt
> 4.4Results-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dcd978be-178b-4ef8-b98b-b685b688478f__4.4Results-SecurityGroups.txt
> 4.4Results-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/443d5c45-3037-45c5-a8ac-0e2cdc0ca12b__4.4Results-Snapshots.txt
> 4.4Results-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/7e95dffd-bbed-46c7-8d95-9ee60f377bb0__4.4Results-Templates.txt
> 4.4Results-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/35ad618d-012b-4dfd-ad3e-9af887654579__4.4Results-Volumes.txt
> 4.4Results-VPNCustomerGateways.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/9fdb47c4-9bba-4ee6-943c-e07a7b5b55e2__4.4Results-VPNCustomerGateways.txt
>
>
> Thanks,
>
> Vinay Varma
>
>
Re: Review Request 21263: CLOODSTACK-6282: Added tests to IP Addess and
divided test_escalations into individual files
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21263/#review43358
-----------------------------------------------------------
Master:
author vinayvarmav <vi...@citrix.com>
Mon, 19 May 2014 11:16:06 +0000 (16:16 +0530)
committer Girish Shilamkar <gi...@clogeny.com>
Mon, 19 May 2014 06:15:17 +0000 (02:15 -0400)
commit ef2012677c8eb47e083a7220dfc30ac001e91567
tree 069cc35e4e03d69bc910f4b358f5a7fe01fc2e1b tree | snapshot
parent b4ad709d321b79f532721cd65f9ecf9584d68ee6
4.4-forward:
author vinayvarmav <vi...@citrix.com>
Mon, 19 May 2014 11:16:06 +0000 (16:16 +0530)
committer Girish Shilamkar <gi...@clogeny.com>
Mon, 19 May 2014 06:17:09 +0000 (02:17 -0400)
commit 378e1da42c235d310df3d39d3d82270ef00546df
tree 428301c4eb8dbaff175a007cf43c2c8027d66cd3 tree | snapshot
parent d43d28ee84424359d5847fa6e53dabad176f037e
- Girish Shilamkar
On May 19, 2014, 11:21 a.m., Vinay Varma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21263/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:21 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOODSTACK-6282: Added tests to IP Addess and divided test_escalations into individual files based on their functionality
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py PRE-CREATION
> test/integration/component/test_escalations_ipaddresses.py PRE-CREATION
> test/integration/component/test_escalations_isos.py PRE-CREATION
> test/integration/component/test_escalations_securitygroups.py PRE-CREATION
> test/integration/component/test_escalations_snapshots.py PRE-CREATION
> test/integration/component/test_escalations_templates.py PRE-CREATION
> test/integration/component/test_escalations_volumes.py PRE-CREATION
> test/integration/component/test_escalations_vpncustomergateways.py PRE-CREATION
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21263/diff/
>
>
> Testing
> -------
>
> Executed the tests in master and 4.4-forward branch and are running fine.
> Attached are the results files for each of the .py file in master and in 4.4-forward branches
>
>
> File Attachments
> ----------------
>
> MasterResults-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/406e33de-cc24-40e3-84c1-5a6d65a5d148__MasterResults-Instances.txt
> MasterResults-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dab25ce0-3d8b-450e-a5d7-8319b3222080__MasterResults-IpAddresses.txt
> MasterResults-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/55ef7b92-ba30-4297-9518-ea41dfa3b873__MasterResults-Isos.txt
> MasterResults-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/db59e0ec-3980-4486-92aa-9f9ca07619dc__MasterResults-SecurityGroups.txt
> MasterResults-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/0f1303df-00dd-4535-bbbb-f8fe24fb00ec__MasterResults-Snapshots.txt
> MasterResults-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/27803766-d7d5-477a-9cb4-00af19707268__MasterResults-Templates.txt
> MasterResults-VPNCustomerGateway.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/fb836ae9-030d-4e47-b482-8329fd891415__MasterResults-VPNCustomerGateway.txt
> MasterResults-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/948f0888-ceac-4202-a430-4e3fb426bc9d__MasterResults-Volumes.txt
> 4.4Results-Instances.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31828ac7-98d9-4f18-a82b-4802e798573e__4.4Results-Instances.txt
> 4.4Results-IpAddresses.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/4f450475-1fbf-4883-8c7c-5594b01fcc94__4.4Results-IpAddresses.txt
> 4.4Results-Isos.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/31c9fc6e-2a82-4dc6-9e22-1ec8b4752695__4.4Results-Isos.txt
> 4.4Results-SecurityGroups.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/dcd978be-178b-4ef8-b98b-b685b688478f__4.4Results-SecurityGroups.txt
> 4.4Results-Snapshots.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/443d5c45-3037-45c5-a8ac-0e2cdc0ca12b__4.4Results-Snapshots.txt
> 4.4Results-Templates.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/7e95dffd-bbed-46c7-8d95-9ee60f377bb0__4.4Results-Templates.txt
> 4.4Results-Volumes.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/35ad618d-012b-4dfd-ad3e-9af887654579__4.4Results-Volumes.txt
> 4.4Results-VPNCustomerGateways.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/09/9fdb47c4-9bba-4ee6-943c-e07a7b5b55e2__4.4Results-VPNCustomerGateways.txt
>
>
> Thanks,
>
> Vinay Varma
>
>
Re: Review Request 21263: CLOODSTACK-6282: Added tests to IP Addess and
divided test_escalations into individual files
Posted by Vinay Varma <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21263/
-----------------------------------------------------------
(Updated May 19, 2014, 11:21 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Modified the tests as per the review comments and uploaded new patch. Executed the tests and allt he tests are running fine. The same patch can be applied for master and 4.4-forward branches.
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
CLOODSTACK-6282: Added tests to IP Addess and divided test_escalations into individual files based on their functionality
Executed the tests in master and 4.4-forward branch and are running fine.
Attached are the results files for each of the .py file in master and in 4.4-forward branches
Diffs (updated)
-----
test/integration/component/test_escalations_instances.py PRE-CREATION
test/integration/component/test_escalations_ipaddresses.py PRE-CREATION
test/integration/component/test_escalations_isos.py PRE-CREATION
test/integration/component/test_escalations_securitygroups.py PRE-CREATION
test/integration/component/test_escalations_snapshots.py PRE-CREATION
test/integration/component/test_escalations_templates.py PRE-CREATION
test/integration/component/test_escalations_volumes.py PRE-CREATION
test/integration/component/test_escalations_vpncustomergateways.py PRE-CREATION
tools/marvin/marvin/lib/base.py 0a6405d
Diff: https://reviews.apache.org/r/21263/diff/
Testing
-------
Executed the tests in master and 4.4-forward branch and are running fine.
Attached are the results files for each of the .py file in master and in 4.4-forward branches
File Attachments
----------------
MasterResults-Instances.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/406e33de-cc24-40e3-84c1-5a6d65a5d148__MasterResults-Instances.txt
MasterResults-IpAddresses.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/dab25ce0-3d8b-450e-a5d7-8319b3222080__MasterResults-IpAddresses.txt
MasterResults-Isos.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/55ef7b92-ba30-4297-9518-ea41dfa3b873__MasterResults-Isos.txt
MasterResults-SecurityGroups.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/db59e0ec-3980-4486-92aa-9f9ca07619dc__MasterResults-SecurityGroups.txt
MasterResults-Snapshots.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/0f1303df-00dd-4535-bbbb-f8fe24fb00ec__MasterResults-Snapshots.txt
MasterResults-Templates.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/27803766-d7d5-477a-9cb4-00af19707268__MasterResults-Templates.txt
MasterResults-VPNCustomerGateway.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/fb836ae9-030d-4e47-b482-8329fd891415__MasterResults-VPNCustomerGateway.txt
MasterResults-Volumes.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/948f0888-ceac-4202-a430-4e3fb426bc9d__MasterResults-Volumes.txt
4.4Results-Instances.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/31828ac7-98d9-4f18-a82b-4802e798573e__4.4Results-Instances.txt
4.4Results-IpAddresses.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/4f450475-1fbf-4883-8c7c-5594b01fcc94__4.4Results-IpAddresses.txt
4.4Results-Isos.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/31c9fc6e-2a82-4dc6-9e22-1ec8b4752695__4.4Results-Isos.txt
4.4Results-SecurityGroups.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/dcd978be-178b-4ef8-b98b-b685b688478f__4.4Results-SecurityGroups.txt
4.4Results-Snapshots.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/443d5c45-3037-45c5-a8ac-0e2cdc0ca12b__4.4Results-Snapshots.txt
4.4Results-Templates.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/7e95dffd-bbed-46c7-8d95-9ee60f377bb0__4.4Results-Templates.txt
4.4Results-Volumes.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/35ad618d-012b-4dfd-ad3e-9af887654579__4.4Results-Volumes.txt
4.4Results-VPNCustomerGateways.txt
https://reviews.apache.org/media/uploaded/files/2014/05/09/9fdb47c4-9bba-4ee6-943c-e07a7b5b55e2__4.4Results-VPNCustomerGateways.txt
Thanks,
Vinay Varma