You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/19 09:50:06 UTC
[GitHub] [airflow] zikun opened a new pull request #9882: TimeSensor should consider timezone-aware DAGs
zikun opened a new pull request #9882:
URL: https://github.com/apache/airflow/pull/9882
Fixes the question posted at https://github.com/apache/airflow/pull/9699#issuecomment-660607930
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9882: TimeSensor should respect DAG timezone
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9882:
URL: https://github.com/apache/airflow/pull/9882#discussion_r457533417
##########
File path: UPDATING.md
##########
@@ -1475,11 +1475,12 @@ arguments, please change `store_serialized_dags` to `read_dags_from_db`.
Similarly, if you were using `DagBag().store_serialized_dags` property, change it to
`DagBag().read_dags_from_db`.
-### TimeSensor will consider default_timezone setting.
+### TimeSensor aware of timezone
Review comment:
```suggestion
### TimeSensor is now timezone aware
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #9882: TimeSensor should respect DAG timezone
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #9882:
URL: https://github.com/apache/airflow/pull/9882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JeffryMAC commented on pull request #9882: TimeSensor should consider timezone-aware DAGs
Posted by GitBox <gi...@apache.org>.
JeffryMAC commented on pull request #9882:
URL: https://github.com/apache/airflow/pull/9882#issuecomment-660786593
I think it would be good to add unit test to check both cases (one with dag aware time zone and one without) to make sure this behavior won't be broken in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org